Re: [PATCH vkd3d 1/6] vkd3d-shader/hlsl: Write SM4 equality instructions.

[Zebediah Figura (she/her)]

On 12/17/21 03:42, Giovanni Mascellani wrote:
> Signed-off-by: Giovanni Mascellani
>
> libs/vkd3d-shader/hlsl_sm4.c | 33 +++++++++++++++++++++++++++++++++
>   1 file changed, 33 insertions(+)
>
> diff --git a/libs/vkd3d-shader/hlsl_sm4.c b/libs/vkd3d-shader/hlsl_sm4.c
> index 2458018f..37a51125 100644
> --- a/libs/vkd3d-shader/hlsl_sm4.c
> +++ b/libs/vkd3d-shader/hlsl_sm4.c
> @@ -1489,6 +1489,39 @@ static void write_sm4_expr(struct hlsl_ctx *ctx,
>               break;
>           }
> -
>    case HLSL_TYPE_BOOL:
> -
>    {
> -
>        switch (expr->op)
> -
>        {
> -
>            case HLSL_OP2_EQUAL:
> -
>            {
> -
>                const struct hlsl_type *src_type = arg1->data_type;
> -
> -
>                switch (src_type->base_type)
> -
>                {
> -
>                    case HLSL_TYPE_FLOAT:
> -
>                        write_sm4_binary_op(buffer, VKD3D_SM4_OP_EQ, &expr->node, arg1, arg2);
> -
>                        break;
> -
> -
>                    case HLSL_TYPE_BOOL:
> -
>                    case HLSL_TYPE_INT:
> -
>                    case HLSL_TYPE_UINT:
> -
>                        write_sm4_binary_op(buffer, VKD3D_SM4_OP_IEQ, &expr->node, arg1, arg2);
> -
>                        break;
> -
> -
>                    default:
> -
>                        break;

This needs a hlsl_fixme().
> -
>                }
> -
>                break;
> -
>            }
> -
> -
>            default:
> -
>                hlsl_fixme(ctx, &expr->node.loc, "SM4 bool \"%s\" expression.\n", debug_hlsl_expr_op(expr->op));
> -
>                break;
> -
>        }
> -
>        break;
> -
>    }
> -
>     default:
>     {
>         struct vkd3d_string_buffer *string;