Paul Vriens wrote:
Just some things that caught my attention:
Could you trim the length for some of the lines somewhat? I also don't think you need all those comments in the first call to ToUnicode.
There is a C++ comment in the patch, should be avoided.
And as a last one, is it possible to use names instead of magic constants?
I just resent my patches, hoping everything is ok now.