Re: [PATCH 1/2] kernel32: Add sxs tests

[Alexandre Julliard]

Fabian Maurer  writes:
> Hello Alexandre,
> > These should be reported as errors, not just skipped.
>
> Right, I'll fix that.
> > Please use the appropriate constant instead of 14001. Also, why does it
> > fail?
>
> Will do. It fails because windows XP doesn't support manifests outside of PE
> files. I could add a comment next to the check for broken().
> > > -
> > >    FreeLibrary(info->module);
> > > -
> > >    FreeLibrary(info->module); /* Make sure it's freed in any case */
> >
> > Why do you need this?
>
> On current wine, one dll gets loaded twice while the other isn't loaded at
> all. For the tests not to fail, I need to free the module twice, to make 100%
> sure it's unloaded before trying to delete it.

Freeing each module once should be enough, even if they happen to be the
same.