27 May
2013
27 May
'13
9:14 a.m.
2013/5/27 Henri Verbeet hverbeet@gmail.com
On 27 May 2013 09:49, Christian Costa titan.costa@gmail.com wrote:
- FIXME("(%p/%p)->(%s,%p): stub\n", iface, This, filename, Texture);
- FIXME("iface %p, filename %s, texture %p stub!\n", iface,
debugstr_a(filename), texture);
Do you really need to change the way traces are displayed?
Yes, you can't use %s for arbitrary application data. The existing traces are also ugly. Arguably that could have been a separate patch, but I'm touching the line anyway because the variable name changed.
No problem with debugstr_a nor variable rename. I meant the format string. The uglyness seems to be a matter of taste. It is used in many places in wine for COM objects. So unless there is a global will to change traces (like LP stuff removal), that would be better to keep traces as they are for consistency with the rest of the code.