Re: [5/6] WineD3D: Write the vshader footer in a separate function
I like this patch - would be great to have more of these:
Lines that fit on the screen in my gnome-terminal: < 50 Average size of six large ARB shader functions, before this patch: 205 (generate pshader, vshader, handle_ins, arb_declarations, init_output_register, gen_arbfp_ffp...)
A couple of other shader questions/suggestions, not related to the patch:
- The "handle_instruction" code seems to be moving away from the design to handle each instruction separately into its own handler - is this really necessary? Does it make sense to create a "loop" intermediate representation in baseshader if the ARB backend needs it to better handle loops?
- There are some elaborate bitfields to track which instructions are called in baseshader.c. Does it make sense to have a more formal framework, where all instructions are tracked or maybe each backend requests which instructions it is interested to track?
Ivan