Re: [PATCH 3/3] mshtml: Add console object stub implementation.

[Jacek Caban]

On 7/6/21 1:08 PM, Paul Gofman wrote:
> - if(dispex_compat_mode(&window->event_target.dispex) >= COMPAT_MODE_IE10 &&
> -
>   !wcscmp(bstrName, L"requestAnimationFrame")) {
> -
>    TRACE("requestAnimationFrame\n");
> -
>    *pid = DISPID_IHTMLWINDOW_IE10_REQUESTANIMATIONFRAME;
> -
>    return S_OK;
> - if(dispex_compat_mode(&window->event_target.dispex) >= COMPAT_MODE_IE10)
> - {
> -
>    if (!wcscmp(bstrName, L"requestAnimationFrame")) {
> -
>        TRACE("requestAnimationFrame\n");
> -
>        *pid = DISPID_IHTMLWINDOW_IE10_REQUESTANIMATIONFRAME;
> -
>        return S_OK;
> -
>    }
> -
>    if (!wcscmp(bstrName, L"console")) {
> -
>        TRACE("console\n");
> -
>        *pid = DISPID_IHTMLWINDOW_IE10_CONSOLE;
> -
>        return S_OK;
> -
>    }

Once we have a private typelib, it would be probably better to use that 
to expose an additional interface with a console object getter from 
window object instead.

Thanks,

Jacek