Re: dpnet: Implement IDirectPlay8LobbiedApplication Initialize

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-05-01 07:42, schrieb Alistair Leslie-Hughes:
> static HRESULT WINAPI IDirectPlay8LobbiedApplicationImpl_RegisterProgram(IDirectPlay8LobbiedApplication *iface,
> @@ -191,6 +201,11 @@ HRESULT DPNET_CreateDirectPlay8LobbiedApp(LPCLASSFACTORY iface, LPUNKNOWN punkOu
>    }
>    app->IDirectPlay8LobbiedApplication_iface.lpVtbl = &DirectPlay8LobbiedApplication_Vtbl;
>    app->ref = 0;
> - app->msghandler = NULL;
> - app->flags = 0;
> - app->usercontext = NULL;
> - app->connection = NULL;

This is redundant, HEAP_ZERO_MEMORY clears that for you. Also, in the other patches you changed the indentation to 4 spaces, but not here. If this was intentional I'm fine with that - just pointing it out.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTYn7KAAoJEN0/YqbEcdMwV2UP/jkWB0vY5CLO+A0z9JISmIJT
V+dlgPTTWHYgxTVBpDVoBlfYl3vmVTqoHPMExWef8lts0Dx1+Gv0pDQZpwUFXJ9P
9jOBZsuyNwcwU1uSm8BvFXQFWs6XCUoQn9nHC5Y9GNezLQy4KRpPX3xkHf1QuHZw
CI/Z8oLwcHT9zy4uWUcYe1ciATCRHx9noLFR7cHIIkOuI1kakptX1DYMp39uo7Hg
qah9QP+yA88MDnXQlUSLOSui0dd7lmbqPTHwsHAm8VCgUWUdqFIT0Yt5kITxZjyW
tKz1XM7aRZ+V4kbdg8R7PbmFdent/xa79ceOnOIg5MQEWc3LBY+ynh5vgAqEUgAA
ynIFlJMyB09D9JRVKj6ETxoIrx+m+FN/z6xD66GvD9ehqQZXH8v+fUc+xyGg0d5o
Yj+2R0HJLUEtN7h3n1o9+8EJ6YhmceyOnu7OtrSN7Mapw7qXT4aESSCiRy8j7c1T
fy3qvPrmEPRjCN8e1Tu0IJn4EyQl6Eke9BB4CXtuxhOgNC+Z2GekgU1k4Dj78iiQ
VXpD9jw/CblEYv+iu4Lvo+E76nHMvF4R0M/UooS+urSnIfKGiNSorMCJOQ+xM1hs
b634KfA1gpfq/foDRY0pVcxQVEbN5nKS8vAiv7wul/bhIoWMAZr2DktBdYP08Ye2
pbmU+Nd4X5lclBbj2Rnq
=jFdr
-----END PGP SIGNATURE-----