On Fri, Dec 19, 2014 at 11:13 AM, Alexandre Julliard julliard@winehq.org wrote:
... I don't think you should be defining libport functions at this point.
I’m really hesitant to make such a change, the proper location for this code is somewhere that can be shared by the wineserver and ntdll. We’ve been field testing these patches for over a year and, to the best of our knowledge, any odd complexity in the code is to combat quirky behavior that we’ve seen as a result of user feedback.
This is actually the reason we implemented DOS Attribute support at all, we wanted to reduce the size of the patches for SD/ACL support to a more manageable size so that the patches would be easier to review. Adding this infrastructure isn’t just important for the SD/ACL patches, it provides compatibility with other software that needs to talk to Windows clients (Samba) and gives us the ability to save state information that we need to fix a variety of Wine bugs.
If moving xattr.c from ports to ntdll is the only thing you would like to have changed, I would be willing to do that, but please review the rest of the patches in this series first. It’s getting frustrating to send these patches over and over with only a little bit of feedback each time. A lot of time has passed since my first try and a lot of people are impatiently waiting to see these issues get fixed.
Best, Erich