Re: [PATCH vkd3d 8/8] tests: Add test for creating heaps.

[Henri Verbeet]

On 20 July 2018 at 17:00, Józef Kucia  wrote:
> +#define check_heap_properties(a, b) check_heap_properties_(__LINE__, a, b)
> +static void check_heap_properties_(unsigned int line,
> -
>    const D3D12_HEAP_PROPERTIES *properties, const D3D12_HEAP_PROPERTIES *expected_properties)
>
> +{
> - D3D12_HEAP_PROPERTIES expected = *expected_properties;
> -
> - if (!expected.CreationNodeMask)
> -
>    expected.CreationNodeMask = 0x1;
> - if (!expected.VisibleNodeMask)
> -
>    expected.VisibleNodeMask = 0x1;
> -
> - ok(properties->Type == expected.Type,
> -
>        "Got type %#x, expected %#x.\n", properties->Type, expected.Type);
> - ok(properties->CPUPageProperty == expected.CPUPageProperty,
> -
>        "Got CPU page properties %#x, expected %#x.\n",
> -
>        properties->CPUPageProperty, expected.CPUPageProperty);
> - ok(properties->MemoryPoolPreference == expected.MemoryPoolPreference,
> -
>        "Got memory pool %#x, expected %#x.\n",
> -
>        properties->MemoryPoolPreference, expected.MemoryPoolPreference);
> - ok(properties->CreationNodeMask == expected.CreationNodeMask,
> -
>        "Got creation node mask %#x, expected %#x.\n",
> -
>        properties->CreationNodeMask, expected.CreationNodeMask);
> - ok(properties->VisibleNodeMask == expected.VisibleNodeMask,
> -
>        "Got visible node mask %#x, expected %#x.\n",
> -
>        properties->VisibleNodeMask, expected.VisibleNodeMask);
>
> +}

You're not using "line" here.