Re: [PATCH 3/7] wmp: Add OPEN/PLAY state change notifications

[Zebediah Figura]

On 12/03/18 23:34, Anton Romanov wrote:
> - switch(dispIdMember) {
> -
>    /* Uncomment below traces to debug wmp events */
> -
>    case DISPID_WMPCOREEVENT_OPENSTATECHANGE:
> -
>        CHECK_EXPECT(OPENSTATE_CHANGE);
> -
>        /*trace("DISPID_WMPCOREEVENT_OPENSTATECHANGE, %d\n", V_UI4(pDispParams->rgvarg));*/
> -
>        break;
> -
>    case DISPID_WMPCOREEVENT_PLAYSTATECHANGE:
> -
>        CHECK_EXPECT(PLAYSTATE_CHANGE);
> -
>        /*trace("DISPID_WMPCOREEVENT_PLAYSTATECHANGE, %d\n", V_UI4(pDispParams->rgvarg));*/
> -
>        break;
> -
>    case DISPID_WMPCOREEVENT_MEDIACHANGE:
> -
>        /*trace("DISPID_WMPCOREEVENT_MEDIACHANGE\n");*/
> -
>        break;
> -
>    case DISPID_WMPCOREEVENT_CURRENTITEMCHANGE:
> -
>        /*trace("DISPID_WMPCOREEVENT_CURRENTITEMCHANGE\n");*/
> -
>        break;
> -
>    default:
> -
>        /*trace("event: %d\n", dispIdMember);*/
> -
>        break;
> - }

I would use "if (winetest_debug > 1) trace(...);", but that's just
personal preference.
> - settings = NULL;
> - hres = IWMPPlayer4_get_settings(player4, &settings);
> - ok(hres == S_OK, "get_settings failed: %08x\n", hres);
> - ok(settings != NULL, "settings = NULL\n");
> -
> - hres = IWMPSettings_put_autoStart(settings, VARIANT_FALSE);
> - ok(hres == S_OK, "Could not put autoStart in IWMPSettings: %08x\n", hres);
> - IWMPSettings_Release(settings);
> -

This seems like it should be part of the previous patch.
> -HRESULT create_media_from_url(BSTR url, IWMPMedia **ppMedia);
> +HRESULT create_media_from_url(BSTR url, IWMPMedia **ppMedia) DECLSPEC_HIDDEN;

Similarly here.
> +#define WMP_OPEN_STATE_PLAYLIST_OPENGING         5

You seem to have introduced a typo here.