Re: [PATCH 1/3] dxgi: Implement IDXGIOutput5 and IDXGIOutput6 stubs.

[Henri Verbeet]

On Thu, 16 Jul 2020 at 10:42, Rémi Bernon  wrote:
> +static HRESULT STDMETHODCALLTYPE dxgi_output_DuplicateOutput1(IDXGIOutput6 *iface,
> -
>    IUnknown *device, UINT flags, UINT format_count, const DXGI_FORMAT *formats,
> -
>    IDXGIOutputDuplication **duplication)
>
> +{
> - FIXME("iface %p, device %p, flags %#x, format_count %d, formats %p, "
> -
>        "output_duplication %p stub!\n", iface, device, flags, format_count,
> -
>        formats, duplication);
> -

"format_count" is unsigned.
> +static HRESULT STDMETHODCALLTYPE dxgi_output_GetDesc1(IDXGIOutput6 *iface,
> -
>    DXGI_OUTPUT_DESC1 *desc)
>
> +{
> - DXGI_OUTPUT_DESC base_desc;
> - HRESULT hr;
> -
> - FIXME("iface %p, desc %p stub!\n", iface, desc);
> -
> - if (!desc)
> -
>    return E_INVALIDARG;
> -
> - if (FAILED(hr = dxgi_output_GetDesc(iface, &base_desc)))
> -
>    return hr;
> -
> - memset(desc, 0, sizeof(*desc));
> - memcpy(desc, &base_desc, sizeof(base_desc));
> -
> - return S_OK;
>
> +}

It would seem best to implement this in a way similar to
dxgi_adapter_GetDesc1().