Re: [PATCH 1/2] kernel32: Add sxs tests

[Alexandre Julliard]

Fabian Maurer  writes:
> - if (!write_resource_file(info->path_tmp, path_dll, "sxs_dll.dll", info->path_dll))
> - {
> -
>   skip("Failed to create file for testing\n");
> -
>   return 1;
> - }
> -
> - if (!write_resource_file(info->path_tmp, exe_manifest, exe_manifest, info->path_manifest_exe))
> - {
> -
>    skip("Failed to create file for testing\n");
> -
>    return 1;
> - }
> -
> - if (!write_resource_file(info->path_tmp, dll_manifest, "sxs_dll.manifest", info->path_manifest_dll))
> - {
> -
>    skip("Failed to create file for testing\n");
> -
>    return 1;
> - }

These should be reported as errors, not just skipped.
> - info->handle_context = CreateActCtxA(&info->context);
> - ok((info->handle_context != NULL && info->handle_context != INVALID_HANDLE_VALUE )|| broken(GetLastError() == 14001),
> -
>        "CreateActCtxA failed: %d\n", GetLastError());
> - if (GetLastError() == 14001)
> - {
> -
>    skip("Failed to create activation context.\n");
> -
>    return 1;
> - }

Please use the appropriate constant instead of 14001. Also, why does it fail?
> -
>    FreeLibrary(info->module);
> -
>    FreeLibrary(info->module); /* Make sure it's freed in any case */

Why do you need this?