On So, 2009-04-26 at 13:18 +1000, Paul TBBle Hampson wrote:
[PATCH 2/2] Add unit tests for junction points using reparse point interface http://www.winehq.org/pipermail/wine-patches/2009-January/067227.html
I didn't test the patches, but from the quick lock:
The test must compile with the Microsoft VC toolchain. That might break, when you define a struct in your source without a guard "#ifndef". Much better is the use of the correct header for that.
- /* Stuff that lives in ntifs.h, according to MSDN */
It's in ddk/ntifs.h in OpenWatcom.
+ buf[bytes] = '\0'; Your debugstrn_w is broken. Your Code writes to unallocated memory, when WideCharToMultiByte need more bytes as you provided.
- (WCHAR*)(((char*)
That looks really ugly.
- static void InitFunctionPointers(void)
A private function with mixed case can be mixed up with an Windows API function, when used. Please use lowcase here.
Please avoid to use the current Directory. I suggest to use a temporary directory below GetTempPath and create your test directories there
- skip("kernel32 does not export required functions.\n");
Please use win_skip here