Re: shell32: Dynamically load an ordinal only export.

[Alexandre Julliard]

Huw Davies  writes:
> dlls/shell32/tests/shlfileop.c |   18 +++++++++---------
>  1 files changed, 9 insertions(+), 9 deletions(-)

This shouldn't be needed, import by ordinal works just fine.

shell32: Dynamically load an ordinal only export.

[Huw Davies]

On Fri, Jan 22, 2010 at 02:01:03PM +0100, Alexandre Julliard wrote:
> Huw Davies  writes:
> > dlls/shell32/tests/shlfileop.c |   18 +++++++++---------
> >  1 files changed, 9 insertions(+), 9 deletions(-)
>
> This shouldn't be needed, import by ordinal works just fine.

I get a failure with make crosstest:

../../../tools/winegcc/winegcc -b i586-mingw32msvc -B../../../tools/winebuild --sysroot=../../.. appbar.cross.o autocomplete.cross.o generated.cross.o progman_dde.cross.o shelllink.cross.o shellpath.cross.o shfldr_special.cross.o shlexec.cross.o shlfileop.cross.o shlfolder.cross.o string.cross.o systray.cross.o rsrc.res testlist.cross.o -o shell32_crosstest.exe -lshell32 -lole32 -loleaut32 -luser32 -ladvapi32 -lkernel32   
shlfileop.cross.o: In function `test_shlmenu':
/home/daviesh/wine/dlls/shell32/tests/shlfileop.c:2232: undefined reference to `_Shell_MergeMenus@24'
/home/daviesh/wine/dlls/shell32/tests/shlfileop.c:2234: undefined reference to `_Shell_MergeMenus@24'

Huw.

shell32: Dynamically load an ordinal only export.

[Alexandre Julliard]

Huw Davies  writes:
> On Fri, Jan 22, 2010 at 02:01:03PM +0100, Alexandre Julliard wrote:
> > Huw Davies  writes:
> > > dlls/shell32/tests/shlfileop.c |   18 +++++++++---------
> > >  1 files changed, 9 insertions(+), 9 deletions(-)
> >
> > This shouldn't be needed, import by ordinal works just fine.
>
> I get a failure with make crosstest:

You have to run make crosstest from the top level for the import
libraries to be built.

shell32: Dynamically load an ordinal only export.

[Huw Davies]

On Fri, Jan 22, 2010 at 02:51:04PM +0100, Alexandre Julliard wrote:
> Huw Davies  writes:
> > On Fri, Jan 22, 2010 at 02:01:03PM +0100, Alexandre Julliard wrote:
> > > Huw Davies  writes:
> > > > dlls/shell32/tests/shlfileop.c |   18 +++++++++---------
> > > >  1 files changed, 9 insertions(+), 9 deletions(-)
> > >
> > > This shouldn't be needed, import by ordinal works just fine.
> >
> > I get a failure with make crosstest:
>
> You have to run make crosstest from the top level for the import
> libraries to be built.

Ah! Thanks!

Huw.