comctl32 failures on Win95, Win98, NT4 asnd Win2K

[Reece Dunn]

These tests are all failing consistently with identical failures on
these platforms:
    combobox - 21 failures; all identical across the platforms.
    datetime - 2 failures; all identical across the platforms.

The rebar tests have 146 failures on some (Win95 and NT4) and 545
failures on others (Win98 and Win2K). This looks like it is due to a
different comctl32 version as a result of a different IE version.

Several of the others have failures on Win95 and Win98 only.

Is anyone going to look at these?

- Reece

[Paul Vriens]

Reece Dunn wrote:
> These tests are all failing consistently with identical failures on
> these platforms:
>     combobox - 21 failures; all identical across the platforms.
>     datetime - 2 failures; all identical across the platforms.
>
> The rebar tests have 146 failures on some (Win95 and NT4) and 545
> failures on others (Win98 and Win2K). This looks like it is due to a
> different comctl32 version as a result of a different IE version.
>
> Several of the others have failures on Win95 and Win98 only.
>
> Is anyone going to look at these?
> - Reece

I already had a brief look and it appears that the failures started happening after:

commit 7a5497b5c06600dc3b58788d0d6132e9f7cb7b87
Author: Francois Gouget 
Date:   Mon Dec 10 01:27:50 2007 +0100

comctl32/tests: InitCommonControlsEx() is missing on Windows 95 so call 
InitCommonControls() instead.

I didn't look further yet though.

[Francois Gouget]

On Tue, 29 Jan 2008, Paul Vriens wrote:
[...]
> > Several of the others have failures on Win95 and Win98 only.
> >
> > Is anyone going to look at these?

I'm sending a patch to fix the InitCommonControlsEx() issue I 
introduced.