Dear winehackers, I sent this patch to wine-patches, with a few iterations of editing, and wondered if I could have some feedback on it, before I just resend it.
Andy
Dear winehackers, I sent this patch to wine-patches, with a few iterations of editing, and wondered if I could have some feedback on it, before I just resend it.
I don't think hardcoding this(as this patch seems to do afaics, I barely know the code) is the right approach here. I think it should be created dynamically based on the devices that are configured
Dear winehackers, I sent this patch to wine-patches, with a few iterations of editing, and wondered if I could have some feedback on it, before I just resend it.
I don't think hardcoding this(as this patch seems to do afaics, I barely know the code) is the right approach here. I think it should be created dynamically based on the devices that are configured
The code in oldconfig.c is called by process.c/__wine_kernel_init(), on server startup. The entries are volatile, and are dynamically created if you count scanning wineprefix/dosdevices/ and doing a stat() on anything named com[1-9] it finds there every time wine starts up. I could just call get_dos_device and let it do the stat calls, but it would be less efficient, and you'd end up with registry entries for the successes of get_default_com_device, not just the ones symlinked in dosdevices
A C Hurst A.Hurst@sheffield.ac.uk writes:
The code in oldconfig.c is called by process.c/__wine_kernel_init(), on server startup. The entries are volatile, and are dynamically created if you count scanning wineprefix/dosdevices/ and doing a stat() on anything named com[1-9] it finds there every time wine starts up. I could just call get_dos_device and let it do the stat calls, but it would be less efficient, and you'd end up with registry entries for the successes of get_default_com_device, not just the ones symlinked in dosdevices
You don't want to depend on the symlinks, things should work without requiring the user to create any symlink. It should depend on what actual devices are present on the machine, and probably be done somewhere in the HAL support.
You don't want to depend on the symlinks, things should work without requiring the user to create any symlink. It should depend on what actual devices are present on the machine,
So, directly stat /dev/ttyS*, then check dosdevices for anything overriding these?
-
A C Hurst -
Alexandre Julliard -
Stefan Dösinger