Re: ole32: Use debugstr_guid() in TRACE() messages.

[Michael Stefaniuc]

Hello Andrey!

On 07/21/2016 05:57 PM, Andrey Gusev wrote:
> ole32-Use-debugstr_guid-in-TRACE-messages.txt
>
> From d360a701eee8b8cf715059d630163a7a21dc3222 Mon Sep 17 00:00:00 2001
> Message-Id: 
> From: Andrey Gusev 
> Date: Thu, 21 Jul 2016 18:56:32 +0300
> Subject: [PATCH] ole32: Use debugstr_guid() in TRACE() messages.
> Signed-off-by: Andrey Gusev
>
> dlls/ole32/classmoniker.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/dlls/ole32/classmoniker.c b/dlls/ole32/classmoniker.c
> index 1bcf58f..00c2f42 100644
> --- a/dlls/ole32/classmoniker.c
> +++ b/dlls/ole32/classmoniker.c
> @@ -231,7 +231,7 @@ static HRESULT WINAPI ClassMoniker_BindToObject(IMoniker* iface,
>      IClassActivator *pActivator;
>      HRESULT hr;
> - TRACE("(%p,%p,%p,%p)\n", pbc, pmkToLeft, riid, ppvResult);
> -
>
> TRACE("(%p,%p,%s,%p)\n", pbc, pmkToLeft, debugstr_guid(riid), ppvResult);
>
> bindopts.cbStruct = sizeof(bindopts);
> IBindCtx_GetBindOptions(pbc, (BIND_OPTS *)&bindopts);
>
> @@ -264,7 +264,7 @@ static HRESULT WINAPI ClassMoniker_BindToStorage(IMoniker* iface,
>                                               REFIID riid,
>                                               VOID** ppvResult)
>  {
> - TRACE("(%p,%p,%p,%p)\n",pbc, pmkToLeft, riid, ppvResult);
> - TRACE("(%p,%p,%s,%p)\n",pbc, pmkToLeft, debugstr_guid(riid), ppvResult);
> return IMoniker_BindToObject(iface, pbc, pmkToLeft, riid, ppvResult);
>
> }
>
> @@ -586,7 +586,7 @@ static HRESULT WINAPI ClassMonikerROTData_QueryInterface(IROTData *iface,REFIID
>  ClassMoniker *This = impl_from_IROTData(iface);
>
> - TRACE("(%p,%p,%p)\n",iface,riid,ppvObject);
> - TRACE("(%p,%s,%p)\n",iface,debugstr_guid(riid),ppvObject);

While you work on this please fix also the whitespace issues in those
lines: Space after ',' and line length should not exceed around 100
chars.
>  return IMoniker_QueryInterface(&This->IMoniker_iface, riid, ppvObject);
>
> }
> -- 2.5.5

bye
    michael