Re: winedbg: add a crash dialog for --auto mode

[Austin English]

2009/4/16 Mikołaj Zalewski :
> This version of the patch uses the now implemented GetProcessImageFileName.
>
> From 549bdead0736d63bc2c05557b6813a64b53aa2ec Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?Miko=C5=82aj_Zalewski?= 
> Date: Sun, 21 Dec 2008 22:28:32 +0100
> Subject: [PATCH] winedbg: add a crash dialog for --auto mode
>
> dlls/kernel32/tests/debugger.c |   96 ++++++++++++++---------
>  programs/winedbg/Makefile.in   |    5 +-
>  programs/winedbg/crashdlg.c    |  172
> ++++++++++++++++++++++++++++++++++++++++
>  programs/winedbg/debugger.h    |    6 ++
>  programs/winedbg/intvar.h      |    3 +
>  programs/winedbg/resource.h    |   34 ++++++++
>  programs/winedbg/rsrc.rc       |   26 ++++++
>  programs/winedbg/rsrc_En.rc    |   53 ++++++++++++
>  programs/winedbg/tgt_active.c  |   16 +++-
>  programs/winedbg/winedbg.c     |   36 +++++---
>  10 files changed, 392 insertions(+), 55 deletions(-)

Howdy Mikołaj,

Looks like this patch caused a regression in
http://bugs.winehq.org/show_bug.cgi?id=18216. Could you have a look?

Before, it would crash, but the app continued on happily. After the
crash dialog patch, the debugger is spawned infinitely, until the X
client limit is reached. Seems to be hitting a loop somewhere...

winedbg: add a crash dialog for --auto mode

[Mikołaj Zalewski]

Austin English wrote:
> 2009/4/16 Mikołaj Zalewski :
> > This version of the patch uses the now implemented GetProcessImageFileName.
> >
> > From 549bdead0736d63bc2c05557b6813a64b53aa2ec Mon Sep 17 00:00:00 2001
> > From: =?utf-8?q?Miko=C5=82aj_Zalewski?= 
> > Date: Sun, 21 Dec 2008 22:28:32 +0100
> > Subject: [PATCH] winedbg: add a crash dialog for --auto mode
> >
> > dlls/kernel32/tests/debugger.c |   96 ++++++++++++++---------
> > programs/winedbg/Makefile.in   |    5 +-
> > programs/winedbg/crashdlg.c    |  172
> > ++++++++++++++++++++++++++++++++++++++++
> > programs/winedbg/debugger.h    |    6 ++
> > programs/winedbg/intvar.h      |    3 +
> > programs/winedbg/resource.h    |   34 ++++++++
> > programs/winedbg/rsrc.rc       |   26 ++++++
> > programs/winedbg/rsrc_En.rc    |   53 ++++++++++++
> > programs/winedbg/tgt_active.c  |   16 +++-
> > programs/winedbg/winedbg.c     |   36 +++++---
> > 10 files changed, 392 insertions(+), 55 deletions(-)
>
> Howdy Mikołaj,
>
> Looks like this patch caused a regression in
> http://bugs.winehq.org/show_bug.cgi?id=18216. Could you have a look?
>
> Before, it would crash, but the app continued on happily. After the
> crash dialog patch, the debugger is spawned infinitely, until the X
> client limit is reached. Seems to be hitting a loop somewhere...

Thanks for the info. I will look into it on Wednesday. If this is the 
debugger crashing (and causing another instance of it to start), it 
should be easy to fix. If this is the application spawning lots of 
subprocesses (e.g. because there is no response after a timeout), this 
could be much harder.

Mikołaj