[PATCH] rpcrt4: Fix ITypeInfo ref count handling.

[Jacek Caban]

From: Kevin Puetz

Signed-off-by: Jacek Caban 
---
  dlls/rpcrt4/ndr_typelib.c | 23 +++++++++++++++++++----
  1 file changed, 19 insertions(+), 4 deletions(-)

[Zebediah Figura]

On 12/16/19 3:19 PM, Jacek Caban wrote:
> From: Kevin Puetz
> Signed-off-by: Jacek Caban
>
> dlls/rpcrt4/ndr_typelib.c | 23 +++++++++++++++++++----
>   1 file changed, 19 insertions(+), 4 deletions(-)

Hello Jacek,

This feels to me like it's making things even more awkward. I'm
presuming the problem is that get_iface_info() is releasing a passed-in
ITypeInfo, in which case I feel like standard COM practice would just be
to not do that. Does the attached patch work for you?

[Jacek Caban]

On 12/16/19 10:52 PM, Zebediah Figura wrote:
> On 12/16/19 3:19 PM, Jacek Caban wrote:
> > From: Kevin Puetz
> > Signed-off-by: Jacek Caban
> >
> > dlls/rpcrt4/ndr_typelib.c | 23 +++++++++++++++++++----
> >    1 file changed, 19 insertions(+), 4 deletions(-)
>
> Hello Jacek,
>
> This feels to me like it's making things even more awkward. I'm
> presuming the problem is that get_iface_info() is releasing a passed-in
> ITypeInfo, in which case I feel like standard COM practice would just be
> to not do that. Does the attached patch work for you?

Sure, I considered doing the same.

Signed-off-by: Jacek Caban

Thanks,

Jacek