Re: Christian Costa : d3dx9_36: Implement skin mesh loading.

[gurketsky]

Hi,

just saw that a bit late. Is there a reason for the rewrite of hr?

Could any call return anything other than D3D_OK and succeed (maybe 
S_FALSE)? It may be possible to drop "if (FAILED(hr)) goto end;" (for 
both cases) and "hr = D3D_OK"... Also the function (parse_mesh) seems to 
overwrite the result anyway to D3D_OK on success, so I see no reason to 
change the hr to D3D_OK in parse_skin_mesh_info.

Cheers
Rico

On 28.05.2013 22:16, Alexandre Julliard wrote:
> -
>    if (SUCCEEDED(hr))
> -
>        hr = mesh_data->skin_info->lpVtbl->SetBoneOffsetMatrix(mesh_data->skin_info, index,
> -
>                 (const D3DMATRIX*)(data + nb_influences * (sizeof(DWORD) + sizeof(FLOAT))));
> -
>    if (FAILED(hr))
> -
>        goto end;
> - }
> -
> - hr = D3D_OK;

Christian Costa : d3dx9_36: Implement skin mesh loading.

[Christian Costa]

Hi,

You're right. This can be simplified. Will send a patch. Thanks.

Christian

2013/5/29 gurketsky
> Hi,
>
> just saw that a bit late. Is there a reason for the rewrite of hr?
>
> Could any call return anything other than D3D_OK and succeed (maybe
> S_FALSE)? It may be possible to drop "if (FAILED(hr)) goto end;" (for both
> cases) and "hr = D3D_OK"... Also the function (parse_mesh) seems to
> overwrite the result anyway to D3D_OK on success, so I see no reason to
> change the hr to D3D_OK in parse_skin_mesh_info.
>
> Cheers
> Rico
>
> On 28.05.2013 22:16, Alexandre Julliard wrote:
> > -
> >    if (SUCCEEDED(hr))
> > -
> >        hr = mesh_data->skin_info->lpVtbl->**
> >
> > SetBoneOffsetMatrix(mesh_data-**>skin_info, index,
> > -
> >                 (const D3DMATRIX*)(data + nb_influences *
> >
> > (sizeof(DWORD) + sizeof(FLOAT))));
> > -
> >    if (FAILED(hr))
> > -
> >        goto end;
> > - }
> > -
> > - hr = D3D_OK;