Re: msi/tests: Test type for INT column.

[Hans Leidekker]

> -
>        "( `Property` CHAR(255), `Value` CHAR(1)  PRIMARY KEY `Property`)" );
> -
>        "( `Property` CHAR(255), `Value` CHAR(1), `Intvalue` INT PRIMARY KEY `Property`)" );
> ok( r == ERROR_SUCCESS , "Failed to create table\n" );

...
> ok( check_record( rec, 2, "Value"), "wrong record type\n");
> - ok( check_record( rec, 3, "IntValue"), "wrong record type\n");

These changes don't agree on the case of 'Intvalue', causing this test to
fail. It would be interesting to see if the remaining column types also need
the extra flag.

-Hans

msi/tests: Test type for INT column.

[Hib Eris]

Hi Hans,

Sorry for this, but my patch just contained a typo, 'Intvalue' and
'IntValue' are just strings that can be set to anything but should match. I
have already sent in new patches for this, but because I am not on the
mailinglist they take some time to arrive. However, these patches are
already outdated, due to Austin's comments.
So after my first two new patches, I have also in six more patches
incorporating Austin's comment and other column types, so they will arrive
soon.

Hib

On Sat, Apr 25, 2009 at 9:48 PM, Hans Leidekker wrote:
> > -
> >        "( `Property` CHAR(255), `Value` CHAR(1)  PRIMARY KEY
>
> `Property`)" );
> > -
> >        "( `Property` CHAR(255), `Value` CHAR(1), `Intvalue` INT
>
> PRIMARY KEY `Property`)" );
> > ok( r == ERROR_SUCCESS , "Failed to create table\n" );
>
> ...
> > ok( check_record( rec, 2, "Value"), "wrong record type\n");
> > - ok( check_record( rec, 3, "IntValue"), "wrong record type\n");
>
> These changes don't agree on the case of 'Intvalue', causing this test to
> fail. It would be interesting to see if the remaining column types also
> need
> the extra flag.
>
> -Hans