Re: [PATCH] userenv: Implement DestroyEnvironmentBlock().

[Maarten Lankhorst]

Hi Lei,

2010/2/2 Lei Zhang :
> Hi,
>
> Over the weekend, someone wrote a Chromium base unit test that calls
> DestroyEnvironmentBlock(). So I guess it's time to implement it. The
> modified Wine test case passed on my WinXP machine.

Are you sure that DestroyEnvironmentBlock needs that null pointer check?

~Maarten

[PATCH] userenv: Implement DestroyEnvironmentBlock().

[Lei Zhang]

On Mon, Feb 1, 2010 at 11:05 PM, Maarten Lankhorst
 wrote:
> Hi Lei,
>
> 2010/2/2 Lei Zhang :
> > Hi,
> >
> > Over the weekend, someone wrote a Chromium base unit test that calls
> > DestroyEnvironmentBlock(). So I guess it's time to implement it. The
> > modified Wine test case passed on my WinXP machine.
>
> Are you sure that DestroyEnvironmentBlock needs that null pointer check?

No, your patch for DestroyEnvironmentBlock seems fine.