vcomp.dll, vcomp90.dll missing on testbot?

[Dan Kegel]

I'm trying to test a better set of stubs for vcomp.dll and its ilk,
but those dlls don't seem to be installed on testbot.

Is vcomp{,90,100}.dll not installed by default on Windows?
If not, should we install it on a few of the VMs?

[Dan Kegel]

On Mon, Aug 6, 2012 at 8:28 AM, Dan Kegel  wrote:
> Is vcomp{,90,100}.dll not installed by default on Windows?
> If not, should we install it on a few of the VMs?

Nevermind for the moment, I probably have a manifest problem.

[Dan Kegel]

On Mon, Aug 6, 2012 at 8:47 AM, Dan Kegel  wrote:
> On Mon, Aug 6, 2012 at 8:28 AM, Dan Kegel  wrote:
> > Is vcomp{,90,100}.dll not installed by default on Windows?
> > If not, should we install it on a few of the VMs?
>
> Nevermind for the moment, I probably have a manifest problem.

OK, I did my homework, and verified that vcomp.dll version 50727.762
is indeed installed on most of the default wine test bots
(see https://testbot.winehq.org/JobDetails.pl?Key=20654 ),
made sure to reference that version in the manifest,
and made sure the resulting exe ran on my Windows laptop.
But winetestbot still complained
  vcomp:0 Test skipped: required DLL vcomp.dll is missing

Did I screw up, or is winetest looking for manifested DLLs wrong somehow?
My test and the test results are at
https://testbot.winehq.org/JobDetails.pl?Key=20656

[André Hentschel]

Am 07.08.2012 06:26, schrieb Dan Kegel:
> On Mon, Aug 6, 2012 at 8:47 AM, Dan Kegel  wrote:
> > On Mon, Aug 6, 2012 at 8:28 AM, Dan Kegel  wrote:
> > > Is vcomp{,90,100}.dll not installed by default on Windows?
> > > If not, should we install it on a few of the VMs?
> >
> > Nevermind for the moment, I probably have a manifest problem.
>
> OK, I did my homework, and verified that vcomp.dll version 50727.762
> is indeed installed on most of the default wine test bots
> (see https://testbot.winehq.org/JobDetails.pl?Key=20654 ),
> made sure to reference that version in the manifest,
> and made sure the resulting exe ran on my Windows laptop.
> But winetestbot still complained
>   vcomp:0 Test skipped: required DLL vcomp.dll is missing
>
> Did I screw up, or is winetest looking for manifested DLLs wrong somehow?
> My test and the test results are at
> https://testbot.winehq.org/JobDetails.pl?Key=20656

I'm not aware of winetestbot taking manifests into account, but i didn't looked at the code.
I bet it only looks into the standard dll folders, so in your case you should test them at vcomp100.dll

[Daniel Jelinski]

Hello,
FWIW, comctl32 version 6 is accessible only with manifest, and there
are tests that reference it. Here's an example:
http://source.winehq.org/source/dlls/comctl32/tests/treeview.c#L1966

[Dan Kegel]

Testing vcomp100 does work, but I shouldn't need to
do that until there's some vcomp100-specific code.

msvcr90/tests just adds a manifest, and that works.

[André Hentschel]

Am 08.08.2012 16:27, schrieb Dan Kegel:
> Testing vcomp100 does work, but I shouldn't need to
> do that until there's some vcomp100-specific code.
>
> msvcr90/tests just adds a manifest, and that works.

not sure why this works for msvcr90, maybe just for a minor version?
anyway, always vcomp100.dll is installed directly without the need for a manifest, so i'd something like in my attachment (it doesn't work, just an example)

[Dan Kegel]

Andre wrote:
> i'd something like in my attachment

Sorry, I should have linked to
http://testbot.winehq.org/JobDetails.pl?Key=20684
where I verified that testing vcomp100 did indeed work around the problem.

I guess that's where I'll put the tests until somebody hits me with a cluestick.

[Dan Kegel]

On Wed, Aug 8, 2012 at 7:27 AM, Dan Kegel  wrote:
> Testing vcomp100 does work, but I shouldn't need to
> do that until there's some vcomp100-specific code.
>
> msvcr90/tests just adds a manifest, and that works.

Heh.  It does add a manifest, but I don't think it works.
See http://bugs.winehq.org/show_bug.cgi?id=31603
- Dan

[Dan Kegel]

On Sun, Sep 2, 2012 at 1:14 PM, Dan Kegel  wrote:
> On Wed, Aug 8, 2012 at 7:27 AM, Dan Kegel  wrote:
> > Testing vcomp100 does work, but I shouldn't need to
> > do that until there's some vcomp100-specific code.
> >
> > msvcr90/tests just adds a manifest, and that works.
>
> Heh.  It does add a manifest, but I don't think it works.
> See http://bugs.winehq.org/show_bug.cgi?id=31603

And I found the problem on testbot, too:
http://bugs.winehq.org/show_bug.cgi?id=31609