Re: winegcc: Link with msvcrt on windows because of __wargv

[James McKenzie]

Alexandre Goujon wrote:
> tools/winegcc/winegcc.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c
> index c2e7876..a929214 100644
> --- a/tools/winegcc/winegcc.c
> +++ b/tools/winegcc/winegcc.c
> @@ -555,6 +555,10 @@ static const char *mingw_unicode_hack( struct options *opts )
>  {
>      char *main_stub = get_temp_file( opts->output_name, ".c" );
> - /* we need to link with msvcrt because of __wargv */
> - if (!opts->use_msvcrt)
> - opts->use_msvcrt = 1;
> - create_file( main_stub, 0644,
>                 "#include <stdlib.h>\n"
>                 "extern int wmain(int,wchar_t**);\n"

Please use [try 2] for any second send.  Keeps things in order and lets
others know that you have responded to errors.  Also, put comments in
the same message as the patch they apply to at the top of the message.

Thank you.

James McKenzie

winegcc: Link with msvcrt on windows because of __wargv

[GOUJON Alexandre]

Le 03/19/10 03:42, James McKenzie a écrit :
> Please use [try 2] for any second send.  Keeps things in order and lets
> others know that you have responded to errors.  Also, put comments in
> the same message as the patch they apply to at the top of the message.
>
> Thank you.
>
> James McKenzi

Ok so the next time, I will use [try n].

But I don't really understand what you mean by "put comments in the same 
message as the patch they apply to at the top of the message".
I mean, I did "git send-email 
out/0002-winegcc-Link-with-msvcrt-on-windows-because-of-__war.patch 
--compose" what sends two mails, the first with my comments only 
(--compose) and the second one with the pacth only.

Do you want a single mail with my comments followed by the content of 
the patch ?
And in this case, how to tell git send-email to do it in that way ?

And a last question : when I send for the first time a patch, should I 
set "In reply-to" to "[e-mail]" or leave it blank ?

Thanks.

winegcc: Link with msvcrt on windows because of __wargv

[James McKenzie]

GOUJON Alexandre wrote:
> Le 03/19/10 03:42, James McKenzie a écrit :
> > Please use [try 2] for any second send.  Keeps things in order and lets
> > others know that you have responded to errors.  Also, put comments in
> > the same message as the patch they apply to at the top of the message.
> >
> > Thank you.
> >
> > James McKenzi
>
> Ok so the next time, I will use [try n].

Thank you.
> But I don't really understand what you mean by "put comments in the
> same message as the patch they apply to at the top of the message".
> I mean, I did "git send-email
> out/0002-winegcc-Link-with-msvcrt-on-windows-because-of-__war.patch
> --compose" what sends two mails, the first with my comments only
> (--compose) and the second one with the pacth only.

I don't you understand what I said.  You had one message with what the
patch should do and then another with the patch.  When you do a git
commit -a, you could add the comments to the file created by git.
> And a last question : when I send for the first time a patch, should I
> set "In reply-to" to "[e-mail]" or leave it blank ?

No. Set the In reply-to to [e-mail].  This way replies will
be sent to the Wine Development mailing list.  Wine-patches should only
have patch information.

James