Re: [PATCH] user32/tests: Fix a leak when creating test icons (Valgrind)

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=23256

Your paranoid android.

=== w864 (32 bit cursoricon) ===
cursoricon.c:1438: Test failed: Create cursor failed.
cursoricon.c:1443: Test failed: GetIconInfo() failed.
cursoricon.c:1445: Test failed: Last error: 1402
cursoricon.c:1460: Test failed: DestroyCursor() failed.
cursoricon.c:1462: Test failed: Last error: 1402
cursoricon.c:1595: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1602: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1603: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0).
cursoricon.c:1604: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1).
cursoricon.c:1610: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1622: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1628: Test failed: Unexpected number of steps in cursor (0 != 3)
cursoricon.c:1637: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1639: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1640: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1643: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1637: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1639: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1.
cursoricon.c:1640: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1643: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1637: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1639: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2.
cursoricon.c:1640: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1643: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1662: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1668: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1674: Test failed: Unexpected number of steps in cursor (0 != 1)
cursoricon.c:1681: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1683: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1684: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1687: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0).
cursoricon.c:1704: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1716: Test failed: Create cursor failed (error = deadbeef).
cursoricon.c:1722: Test failed: Unexpected number of steps in cursor (0 != 3)
cursoricon.c:1733: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1735: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1736: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de).
cursoricon.c:1739: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1733: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1735: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1.
cursoricon.c:1736: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe).
cursoricon.c:1739: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1733: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1735: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2.
cursoricon.c:1736: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe).
cursoricon.c:1739: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1747: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:2624: Test failed: LoadImage() failed with 0.
cursoricon.c:2624: Test failed: LoadImage() failed with 0.

=== w1064 (32 bit cursoricon) ===
cursoricon.c:1438: Test failed: Create cursor failed.
cursoricon.c:1443: Test failed: GetIconInfo() failed.
cursoricon.c:1445: Test failed: Last error: 1402
cursoricon.c:1460: Test failed: DestroyCursor() failed.
cursoricon.c:1462: Test failed: Last error: 1402
cursoricon.c:1595: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1602: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1603: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0).
cursoricon.c:1604: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1).
cursoricon.c:1610: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1622: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1628: Test failed: Unexpected number of steps in cursor (0 != 3)
cursoricon.c:1637: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1639: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1640: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1643: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1637: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1639: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1.
cursoricon.c:1640: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1643: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1637: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1639: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2.
cursoricon.c:1640: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1643: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1662: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1668: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1674: Test failed: Unexpected number of steps in cursor (0 != 1)
cursoricon.c:1681: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1683: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1684: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1687: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0).
cursoricon.c:1704: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1716: Test failed: Create cursor failed (error = deadbeef).
cursoricon.c:1722: Test failed: Unexpected number of steps in cursor (0 != 3)
cursoricon.c:1733: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1735: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1736: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de).
cursoricon.c:1739: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1733: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1735: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1.
cursoricon.c:1736: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe).
cursoricon.c:1739: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1733: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1735: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2.
cursoricon.c:1736: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe).
cursoricon.c:1739: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1747: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:2624: Test failed: LoadImage() failed with 0.
cursoricon.c:2624: Test failed: LoadImage() failed with 0.

=== w864 (64 bit cursoricon) ===
cursoricon.c:1438: Test failed: Create cursor failed.
cursoricon.c:1443: Test failed: GetIconInfo() failed.
cursoricon.c:1445: Test failed: Last error: 1402
cursoricon.c:1460: Test failed: DestroyCursor() failed.
cursoricon.c:1462: Test failed: Last error: 1402
cursoricon.c:1595: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1602: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1603: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0).
cursoricon.c:1604: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1).
cursoricon.c:1610: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1622: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1628: Test failed: Unexpected number of steps in cursor (0 != 3)
cursoricon.c:1637: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1639: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1640: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1643: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1637: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1639: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1.
cursoricon.c:1640: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1643: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1637: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1639: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2.
cursoricon.c:1640: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1643: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1662: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1668: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1674: Test failed: Unexpected number of steps in cursor (0 != 1)
cursoricon.c:1681: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1683: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1684: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1687: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0).
cursoricon.c:1704: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1716: Test failed: Create cursor failed (error = deadbeef).
cursoricon.c:1722: Test failed: Unexpected number of steps in cursor (0 != 3)
cursoricon.c:1733: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1735: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1736: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de).
cursoricon.c:1739: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1733: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1735: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1.
cursoricon.c:1736: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe).
cursoricon.c:1739: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1733: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1735: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2.
cursoricon.c:1736: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe).
cursoricon.c:1739: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1747: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:2624: Test failed: LoadImage() failed with 0.
cursoricon.c:2624: Test failed: LoadImage() failed with 0.

=== w1064 (64 bit cursoricon) ===
cursoricon.c:1438: Test failed: Create cursor failed.
cursoricon.c:1443: Test failed: GetIconInfo() failed.
cursoricon.c:1445: Test failed: Last error: 1402
cursoricon.c:1460: Test failed: DestroyCursor() failed.
cursoricon.c:1462: Test failed: Last error: 1402
cursoricon.c:1595: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1602: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1603: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0).
cursoricon.c:1604: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1).
cursoricon.c:1610: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1622: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1628: Test failed: Unexpected number of steps in cursor (0 != 3)
cursoricon.c:1637: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1639: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1640: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1643: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1637: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1639: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1.
cursoricon.c:1640: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1643: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1637: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1639: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2.
cursoricon.c:1640: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1643: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1662: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1668: Test failed: Create cursor failed (error = -559038737).
cursoricon.c:1674: Test failed: Unexpected number of steps in cursor (0 != 1)
cursoricon.c:1681: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1683: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1684: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef).
cursoricon.c:1687: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0).
cursoricon.c:1704: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:1716: Test failed: Create cursor failed (error = deadbeef).
cursoricon.c:1722: Test failed: Unexpected number of steps in cursor (0 != 3)
cursoricon.c:1733: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1735: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0.
cursoricon.c:1736: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de).
cursoricon.c:1739: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1733: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1735: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1.
cursoricon.c:1736: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe).
cursoricon.c:1739: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1733: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000).
cursoricon.c:1474: Test failed: GetIconInfo() failed
cursoricon.c:1735: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2.
cursoricon.c:1736: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe).
cursoricon.c:1739: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3).
cursoricon.c:1747: Test failed: DestroyCursor() failed (error = 1402).
cursoricon.c:2624: Test failed: LoadImage() failed with 0.
cursoricon.c:2624: Test failed: LoadImage() failed with 0.

[PATCH] user32/tests: Fix a leak when creating test icons (Valgrind)

[Nikolay Sivov]

On 31.05.2016 14:52, Marvin wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> https://testbot.winehq.org/JobDetails.pl?Key=23256
>
> Your paranoid android.
>
> === w864 (32 bit cursoricon) ===
>
> === w1064 (32 bit cursoricon) ===
>
> === w864 (64 bit cursoricon) ===
>
> === w1064 (64 bit cursoricon) ===

Those are already failing without this patch.