Re: [PATCH 6/8] winhttp: Added schannel-based netconn_get_cipher_strength implementation

[Hans Leidekker]

On Tue, 2013-01-22 at 16:49 +0100, Jacek Caban wrote:
> @@ -1460,6 +1460,13 @@ int netconn_get_cipher_strength( netconn_t *conn )
>      pSSL_CIPHER_get_bits( cipher, &bits );
>      return bits;
>  #else
> - return 0;
> - SecPkgContext_ConnectionInfo conn_info;
> - SECURITY_STATUS res;
> -
> - if (!conn->secure) return 0;
> - res = QueryContextAttributesW(&conn->ssl_ctx, SECPKG_ATTR_REMOTE_CERT_CONTEXT, (void*)&conn_info);

That should be SECPKG_ATTR_CONNECTION_INFO.

[PATCH 6/8] winhttp: Added schannel-based netconn_get_cipher_strength implementation

[Jacek Caban]

On 01/22/13 17:22, Hans Leidekker wrote:
> On Tue, 2013-01-22 at 16:49 +0100, Jacek Caban wrote:
> > @@ -1460,6 +1460,13 @@ int netconn_get_cipher_strength( netconn_t *conn )
> >      pSSL_CIPHER_get_bits( cipher, &bits );
> >      return bits;
> >  #else
> > - return 0;
> > - SecPkgContext_ConnectionInfo conn_info;
> > - SECURITY_STATUS res;
> > -
> > - if (!conn->secure) return 0;
> > - res = QueryContextAttributesW(&conn->ssl_ctx, SECPKG_ATTR_REMOTE_CERT_CONTEXT, (void*)&conn_info);
>
> That should be SECPKG_ATTR_CONNECTION_INFO.

Good catch, thanks. I will send a fixed version.

Jacek