Is there any particular reason you're not simply using the compiler's support for bit-fields?
Is there any particular reason you're not simply using the compiler's support for bit-fields?
Mostly because I've written this code before you mentioned them to me. I think it can't hurt to ask Alexandre if bitfields are ok to use in Wine. How's the support among compilers(older gcc versions? Non-gcc compilers like icc and msvc?)
2008/7/28 Stefan Dösinger stefan@codeweavers.com:
Mostly because I've written this code before you mentioned them to me. I think it can't hurt to ask Alexandre if bitfields are ok to use in Wine. How's the support among compilers(older gcc versions? Non-gcc compilers like icc and msvc?)
Afaik bit-fields are at least part of C89. I know for sure gcc and msvc support them, and would be surprised if icc didn't.
On Mon, 28 Jul 2008, H. Verbeet wrote:
2008/7/28 Stefan Dösinger stefan@codeweavers.com:
Mostly because I've written this code before you mentioned them to me. I think it can't hurt to ask Alexandre if bitfields are ok to use in Wine. How's the support among compilers(older gcc versions? Non-gcc compilers like icc and msvc?)
Afaik bit-fields are at least part of C89. I know for sure gcc and msvc support them, and would be surprised if icc didn't.
I've seen PSDK structures that have bitfields which means we already use them. So there's no issue with using them for our own stuff too.
Afaik bit-fields are at least part of C89. I know for sure gcc and msvc support them, and would be surprised if icc didn't.
On the other hand, having the bits not in bitfields makes it easier to build the hash value in the next patch
-
Francois Gouget -
H. Verbeet -
Stefan Dösinger