Re: systray[2/4]: correctly handle icon addition/deletion

[Kirill K. Smirnov]

В сообщении от Thursday 07 February 2008 02:58:42 вы написали:
> Kirill K. Smirnov wrote:
> > @@ -71,6 +71,12 @@ struct icon
> >  static struct tray tray;
> >  static BOOL hide_systray;
> >
> > +static BOOL add_icon(NOTIFYICONDATAW *nid);
> > +static BOOL modify_icon(NOTIFYICONDATAW *nid);
> > +static BOOL delete_icon(const NOTIFYICONDATAW *nid);
> > +static BOOL delete_icon_directly(struct icon *icon);
> > +static BOOL display_icon(struct icon *icon, BOOL hide);
> > -
> >
> > /* adaptor code */
> >
> > #define ICON_SIZE GetSystemMetrics(SM_CXSMICON)
>
> I don't see any reason why you need to add forward declarations for all
> of these functions.

Hmmmm..... It may be an artifact from my development when I need to call them 
from places before they defined....
Anyway, is it really bad to have them declared here? If so I'll remove it.

--
Kirill

systray[2/4]: correctly handle icon addition/deletion

[James Hawkins]

On Feb 6, 2008 6:24 PM, Kirill K. Smirnov  wrote:
> В сообщении от Thursday 07 February 2008 02:58:42 вы написали:
> > Kirill K. Smirnov wrote:
> > > @@ -71,6 +71,12 @@ struct icon
> > >  static struct tray tray;
> > >  static BOOL hide_systray;
> > >
> > > +static BOOL add_icon(NOTIFYICONDATAW *nid);
> > > +static BOOL modify_icon(NOTIFYICONDATAW *nid);
> > > +static BOOL delete_icon(const NOTIFYICONDATAW *nid);
> > > +static BOOL delete_icon_directly(struct icon *icon);
> > > +static BOOL display_icon(struct icon *icon, BOOL hide);
> > > -
> > >
> > > /* adaptor code */
> > >
> > > #define ICON_SIZE GetSystemMetrics(SM_CXSMICON)
> >
> > I don't see any reason why you need to add forward declarations for all
> > of these functions.
>
> Hmmmm..... It may be an artifact from my development when I need to call them
> from places before they defined....
> Anyway, is it really bad to have them declared here? If so I'll remove it.

Forward declarations usually can, and should be, avoided.  Just
rearrange the code.