test.winehq.org

[Stefan Leichter]

Hello,

i just noticed that the test results for advapi32:service tests are not 
available for the last build (http://test.winehq.org/data/200801301937/). It 
looks like the parser did not create the files.

Can someone familar with this stuff have a look?

Thanks Stefan

[Reece Dunn]

On 31/01/2008, Stefan Leichter  wrote:
> Hello,
>
> i just noticed that the test results for advapi32:service tests are not
> available for the last build (http://test.winehq.org/data/200801301937/). It
> looks like the parser did not create the files.
>
> Can someone familar with this stuff have a look?

I noticed during the run on my Vista machine that the passed, failed,
todo line for one of the tests outputted to the console. I don't know
for which test it was though.

Also, the security tests (the previous one) have two output lines, e.g.:

security: 18 tests executed (0 marked as todo, 0 failures), 0 skipped.
  security: 944 tests executed (0 marked as todo, 0 failures), 1 skipped.

- Reece

[Paul Vriens]

Reece Dunn wrote:
> On 31/01/2008, Stefan Leichter  wrote:
> > Hello,
> >
> > i just noticed that the test results for advapi32:service tests are not
> > available for the last build (http://test.winehq.org/data/200801301937/). It
> > looks like the parser did not create the files.
> >
> > Can someone familar with this stuff have a look?
>
> I noticed during the run on my Vista machine that the passed, failed,
> todo line for one of the tests outputted to the console. I don't know
> for which test it was though.
>
> Also, the security tests (the previous one) have two output lines, e.g.:
>
> security: 18 tests executed (0 marked as todo, 0 failures), 0 skipped.
>   security: 944 tests executed (0 marked as todo, 0 failures), 1 skipped.
> - Reece

Multiple lines of output like that is common and taken care of by the framework.

AFAIK this usually happens when childprocesses/threads product output 
information like that.

[Francois Gouget]

On Thu, 31 Jan 2008, Reece Dunn wrote:
[...]
> Also, the security tests (the previous one) have two output lines, e.g.:
>
> security: 18 tests executed (0 marked as todo, 0 failures), 0 skipped.
>   security: 944 tests executed (0 marked as todo, 0 failures), 1 skipped.

Yes, this typically happens when one does tests in a child process.
This is wrong because it breaks 'make xxx.ok'.

The reason is that the parent process does not know whether some tests 
failed in the child process or not, and thus it will return 0. Make will 
thus think that everything went well and so 'make xxx.ok' will succeed 
eventhough it should have failed.

Alexandre relies on 'make test' to give him a reliable result so this 
may/will cause him not to notice new test failures introduced by a patch 
if they happen in a child process.

In dlls/kernel32/tests/debugger.c I have code that passes data from the 
child process back to the parent so the tests can be done in the parent, 
specifically to avoid this problem. But maybe we should have a general 
mechanism to deal with this.

[Paul Vriens]

Stefan Leichter wrote:
> Hello,
>
> i just noticed that the test results for advapi32:service tests are not 
> available for the last build (http://test.winehq.org/data/200801301937/). It 
> looks like the parser did not create the files.
>
> Can someone familar with this stuff have a look?
>
> Thanks Stefan

I don't think it has something to do with the testsuite but rather with some 
oddity of the webserver/browser.

When you click on the service test for 
http://test.winehq.org/data/200801301937/2003_fg-win2003es/advapi32:service....
you get an empty page.

When you however go to the directory 
http://test.winehq.org/data/200801301937/2003_fg-win2003es/ you will see that 
the file is there. But I can't download it though.

When I now look at the test.winehq.org server itself:

pvriens@wine:/home/winehq/opt/winetest/data/200801301937/2003_fg-win2003es$ more 
advapi32:service.txt
service.c:941: Test failed: expected error ERROR_INVALID_ADDRESS, got 122
service: 196 tests executed (0 marked as todo, 1 failure), 0 skipped.