Patch looks good to me. Since I cannot read it, I need someone else here on wine devel to vouch for the translation. Just to make sure it is legit and not a very tricky spam or just a pass through google translate.
You will also need to add a string to the $this->languages array in the data class (include/data.php)
I also noticed we are still using .cvsignore files, oops. Those should get moved to .gitignore, but I can do that later.
-N
On Tue 29 Jan 2013 08:34:28 AM CST, Jactry wrote:
Hi Jeremy,
2013/1/30 Jeremy Newman jnewman@codeweavers.com
Patch looks good to me. Since I cannot read it, I need someone else here on wine devel to vouch for the translation. Just to make sure it is legit and not a very tricky spam or just a pass through google translate.
So happy to hear that. But please ignore this patch first and I will send a newer soon. There was some wrong in the first patch...
You will also need to add a string to the $this->languages array in the data class (include/data.php)
Thanks for your remind. And I found that was anthor problem: the folder of
Simplified Chinese in "templates" named "zh_CN", but the picture in "images/lang/" named "zh.png". I think "zh.png" should be renamed as "zh_CN.png". ( In general, something about "Simplified Chinese" was signed as "zh_CN" and "zh_TW" was left for "Traditional Chinese")
2013/1/30 Jeremy Newman jnewman@codeweavers.com
Patch looks good to me. Since I cannot read it, I need someone else here on wine devel to vouch for the translation. Just to make sure it is legit and not a very tricky spam or just a pass through google translate.
You will also need to add a string to the $this->languages array in the data class (include/data.php)
I also noticed we are still using .cvsignore files, oops. Those should get moved to .gitignore, but I can do that later.
-N
On Tue 29 Jan 2013 08:34:28 AM CST, Jactry wrote:
Hi Jeremy,
2013/1/30 Jeremy Newman jnewman@codeweavers.com:
Patch looks good to me. Since I cannot read it, I need someone else here
on wine devel to vouch for the >translation. Just to make sure it is legit and not a very tricky spam or just a pass through google translate.
So happy to hear that. But please ignore this patch first and I will send a newer soon. There was some wrong in the first patch...
You will also need to add a string to the $this->languages array in the
data class (include/data.php)
Thanks for your remind. And I found that was anthor problem: the folder of Simplified Chinese in "templates" named "zh_CN", but the picture in "images/lang/" named "zh.png". I think "zh.png" should be renamed as "zh_CN.png". ( In general, something about "Simplified Chinese" was signed as "zh_CN" and "zh_TW" was left for "Traditional Chinese")
2013/1/30 Jeremy Newman jnewman@codeweavers.com
Patch looks good to me. Since I cannot read it, I need someone else here on wine devel to vouch for the translation. Just to make sure it is legit and not a very tricky spam or just a pass through google translate.
You will also need to add a string to the $this->languages array in the data class (include/data.php)
I also noticed we are still using .cvsignore files, oops. Those should get moved to .gitignore, but I can do that later.
-N
On Tue 29 Jan 2013 08:34:28 AM CST, Jactry wrote:
--- On Wed, 30/1/13, Jactry jactry92@gmail.com wrote:
From: Jactry jactry92@gmail.com Subject: Re: [website] Added simplified chinese To: "Jeremy Newman" jnewman@codeweavers.com Cc: "wine-devel" wine-devel@winehq.org Date: Wednesday, 30 January, 2013, 16:28
Hi Jeremy, 2013/1/30 Jeremy Newman jnewman@codeweavers.com:>Patch looks good to me. Since I cannot read it, I need someone else here on wine devel to vouch for the >translation. Just to make sure it is legit and not a very tricky spam or just a pass through google translate.
So happy to hear that. But please ignore this patch first and I will send a newer soon. There was some wrong in the first patch...
You will also need to add a string to the $this->languages array in the data class (include/data.php)
Thanks for your remind. And I found that was anthor problem: the folder of Simplified Chinese in "templates" named "zh_CN", but the picture in "images/lang/" named "zh.png". I think "zh.png" should be renamed as "zh_CN.png". ( In general, something about "Simplified Chinese" was signed as "zh_CN" and "zh_TW" was left for "Traditional Chinese")In glibc 2.16, the following locales are defined:
zh zh-CN zh_HK zh_TW.Big5 zh_CN zh_CN.GB2312 zh_TW
Not to forget zh_HK... I also seem to have come across zh_SG (for Singapore) although I cannot remember what context.
2013/1/30 Jeremy Newman jnewman@codeweavers.com
Patch looks good to me. Since I cannot read it, I need someone else here on wine devel to vouch for the translation. Just to make sure it is legit and not a very tricky spam or just a pass through google translate.
You will also need to add a string to the $this->languages array in the data class (include/data.php)
I also noticed we are still using .cvsignore files, oops. Those should get moved to .gitignore, but I can do that later.
-N
On Tue 29 Jan 2013 08:34:28 AM CST, Jactry wrote:
-----Inline Attachment Follows-----
--- On Wed, 30/1/13, Jeremy Newman jnewman@codeweavers.com wrote:
Patch looks good to me. Since I cannot read it, I need someone else here on wine devel to vouch for the translation. Just to make sure it is legit and not a very tricky spam or just a pass through google translate.
You will also need to add a string to the $this->languages array in the data class (include/data.php)
I also noticed we are still using .cvsignore files, oops. Those should get moved to .gitignore, but I can do that later.
The translation of the content is largely okay. I also find it a bit strange with the .cvsignore file, and also the google_analytic.template file - I think that probably should be factored out into a language-neutral template.
Just a note that the encoding is zh_CN.utf8, rather than the more-common-in-China zh_CN.GB18030 .
(I think you can find me as a distant-past code contributor - got a couple of patches in, in the mshtml area, I think, a long time ago - and active on bugzilla for some years).
Thanks for looking at it.
I'll do a mass move of the .cvsignore files later. Jactry should just leave it out if his final patch.
We prefer UTF-8 as that is what the underlying template engine of the website understands. Modern browsers should be able to use it just fine (hopefully, even in China).
-N
On Wed 30 Jan 2013 10:45:28 AM CST, Hin-Tak Leung wrote:
--- On Wed, 30/1/13, Jeremy Newman jnewman@codeweavers.com wrote:
Patch looks good to me. Since I cannot read it, I need someone else here on wine devel to vouch for the translation. Just to make sure it is legit and not a very tricky spam or just a pass through google translate.
You will also need to add a string to the $this->languages array in the data class (include/data.php)
I also noticed we are still using .cvsignore files, oops. Those should get moved to .gitignore, but I can do that later.
The translation of the content is largely okay. I also find it a bit strange with the .cvsignore file, and also the google_analytic.template file - I think that probably should be factored out into a language-neutral template.
Just a note that the encoding is zh_CN.utf8, rather than the more-common-in-China zh_CN.GB18030 .
(I think you can find me as a distant-past code contributor - got a couple of patches in, in the mshtml area, I think, a long time ago - and active on bugzilla for some years).
On Thu, Jan 31, 2013 at 1:24 AM, Jeremy Newman jnewman@codeweavers.com wrote:
We prefer UTF-8 as that is what the underlying template engine of the website understands. Modern browsers should be able to use it just fine (hopefully, even in China).
Don't worry about UTF-8, let's commit the patch and see what happens. <grin> According to http://tongji.baidu.com/data/browser , 74% of Chinese users are using MSIE{6,8,9}, if MSIE has any trouble to display UTF-8 Chinese text, we could consider providing a binary patch to MS, or maybe even source code patch, we already has a gecko-based IE which supports UTF-8 pretty good...
Just a joke, but seriously, UTF-8 is supported even in China :)
The translation part of the patch looks good to me, but as I know Jactry is working on an improved version, let's wait for his new work.
Thanks.
-- Regards, Qian Hong
- Sent from Ubuntu http://www.ubuntu.com/
-
Hin-Tak Leung -
Hin-Tak Leung -
Jactry -
Jeremy Newman -
Qian Hong