Getting my test for DrawIcon and DrawIconEx included

[Joel Holdsworth]

Is there a reason why my patch (attached) hasn't been included yet? This
is my first patch, so maybe someone can help me get it in.

Joel

[Nikolay Sivov]

Joel Holdsworth wrote:
> Is there a reason why my patch (attached) hasn't been included yet? This
> is my first patch, so maybe someone can help me get it in.
>
> Joel+

Just a quick look:

1)

+    Sleep(200);
+
+    return hWnd;
+}
+

Why are you sleeping here?

2) Why do you need a window here? It seems that you use it only to retrieve HDC.
3) It's better to pass a LINE in such cases (to check_icon_draw helper):

+        todo_wine
+        {
+            check_icon_draw(hwnd, drawiconex, TRUE, 0xFFA0B0C0, 32, 0x00FFFFFF, 0x00C0B0A0);
+
+            check_icon_draw(hwnd, drawiconex, FALSE, 0x80A0B0C0, 32, 0x00000000, 0x00605850);
+            check_icon_draw(hwnd, drawiconex, TRUE, 0x80A0B0C0, 32, 0x00000000, 0x00605850);
+            check_icon_draw(hwnd, drawiconex, FALSE, 0x80A0B0C0, 32, 0x00FFFFFF, 0x00DFD7CF);
+            check_icon_draw(hwnd, drawiconex, TRUE, 0x80A0B0C0, 32, 0x00FFFFFF, 0x00DFD7CF);
+
+            check_icon_draw(hwnd, drawiconex, FALSE, 0x01FFFFFF, 32, 0x00000000, 0x00010101);
+            check_icon_draw(hwnd, drawiconex, TRUE, 0x01FFFFFF, 32, 0x00000000, 0x00010101);
+            check_icon_draw(hwnd, drawiconex, FALSE, 0xFEFFFFFF, 32, 0x00000000, 0x00FEFEFE);
+            check_icon_draw(hwnd, drawiconex, TRUE, 0xFEFFFFFF, 32, 0x00000000, 0x00FEFEFE);
+        }

4) How do these tests behave on older platforms < NT5 by means of alpha 
channel? Maybe it's handled somehow, put a comment about it please.