Re: rpcrt4: Restore original error code when ReadFile fails with ERROR_MORE_DATA.

[Alexandre Julliard]

Sebastian Lackner  writes:
> Required when named pipe messagemode is implemented.

Restoring last error is in general wrong. You'll need a better reason to
justify this.

rpcrt4: Restore original error code when ReadFile fails with ERROR_MORE_DATA.

[Sebastian Lackner]

On 09.06.2015 10:31, Alexandre Julliard wrote:
> Sebastian Lackner  writes:
> > Required when named pipe messagemode is implemented.
>
> Restoring last error is in general wrong. You'll need a better reason to
> justify this.

The problem I am trying to fix with this patch occurs during connection
teardown. See for example setupapi.SetupInstallServicesFromInfSectionW, where
the error code is set before calling CloseServiceHandle(), which will send
additional RPC messages. The alternative solutions would be:
* Only restore error code for CloseServiceHandle()
* Restructure setupapi code to set the error as a last step, after calling CloseServiceHandle.

Regards,
Sebastian

rpcrt4: Restore original error code when ReadFile fails with ERROR_MORE_DATA.

[Alexandre Julliard]

Sebastian Lackner  writes:
> - Restructure setupapi code to set the error as a last step, after calling CloseServiceHandle.

Yes, last error should always be set as the last step. Any call in
between can legitimately modify it.