Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 4)

[Charles Davis]

Any concerns? I've gone over this patch, and I don't see anything major.

If it will make you feel any better, I just ran the tests under a WoW64
environment on Linux, and they passed.

Chip

[PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 4)

[Scott Ritchie]

On 10/25/2010 03:03 PM, Charles Davis wrote:
> Any concerns? I've gone over this patch, and I don't see anything major.
>
> If it will make you feel any better, I just ran the tests under a WoW64
> environment on Linux, and they passed.
>
> Chip

Will your patch detect a Wine folder on ciopfs and work well in it?  I
admit this isn't a common use case (yet), but I intend to change this.

-Scott Ritchie

[PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 4)

[Charles Davis]

On 10/27/10 8:54 AM, Scott Ritchie wrote:
> On 10/25/2010 03:03 PM, Charles Davis wrote:
> > Any concerns? I've gone over this patch, and I don't see anything major.
> >
> > If it will make you feel any better, I just ran the tests under a WoW64
> > environment on Linux, and they passed.
> >
> > Chip
>
> Will your patch detect a Wine folder on ciopfs and work well in it?  I
> admit this isn't a common use case (yet), but I intend to change this.

Yep. I incorporated your idea (testing for a hidden .ciopfs file in the
directory), and I made sure I tested the patch on a ciopfs.

I created the hidden file manually; we still have to make the FS driver
create the file automatically.

Chip