MSI Patch Feedback

[Andrew Nguyen]

Hello,

I've written a few patches against dlls/msi/action.c in an effort to
rectify a difference in behavior with an MSI-based installer between
Windows and Wine with regard to environment variable processing.
Behavior not explicitly enumerated by MSDN is noted when a combination
of the environment table "+" name prefix and "[~]" value expression
are combined. How should I attempt to test the changes I have made,
and is there anything I can do to improve the quality of my changes?
Feedback is appreciated!

-Andrew

[Austin English]

On Fri, Jan 9, 2009 at 3:18 AM, Andrew Nguyen  wrote:
> Hello,
>
> I've written a few patches against dlls/msi/action.c in an effort to
> rectify a difference in behavior with an MSI-based installer between
> Windows and Wine with regard to environment variable processing.
> Behavior not explicitly enumerated by MSDN is noted when a combination
> of the environment table "+" name prefix and "[~]" value expression
> are combined. How should I attempt to test the changes I have made,
> and is there anything I can do to improve the quality of my changes?
> Feedback is appreciated!
>
> -Andrew

I don't see testcases for any of these changes. Adding conformance
tests would be the best first course of action:

http://wiki.winehq.org/ConformanceTests
http://wiki.winehq.org/WritingConformanceTests

[ricardo filipe]

> > "How should I attempt to test the changes I have made"
>
> I don't see testcases for any of these changes. Adding conformance
> tests would be the best first course of action:
>
> http://wiki.winehq.org/ConformanceTests
> http://wiki.winehq.org/WritingConformanceTests
>
> --
> -Austin

he is asking how he should test... i think he knows he has to do them :) 
i had the same problem a while back and got no response too so it's on standby...
_________________________________________________________________
Show them the way! Add maps and directions to your party invites. 
http://www.microsoft.com/windows/windowslive/events.aspx

[James Hawkins]

On Fri, Jan 9, 2009 at 9:52 AM, ricardo filipe
 wrote:
> > > "How should I attempt to test the changes I have made"
> >
> > I don't see testcases for any of these changes. Adding conformance
> > tests would be the best first course of action:
> >
> > http://wiki.winehq.org/ConformanceTests
> > http://wiki.winehq.org/WritingConformanceTests
> >
> > --
> > -Austin
>
> he is asking how he should test... i think he knows he has to do them :)
> i had the same problem a while back and got no response too so it's on standby...

There is no way to test the setting of environment variables by msi.
You can't query the changed environment variable until the process
exits.  Using a child process doesn't help either.