Re: makefiles: add a notest target

[Maarten Lankhorst]

Hi Lei,

Lei Zhang schreef:
> Hi,
>
> This patch adds a notest target to build everything but the dll unit
> tests and winetest. This cuts down build time by 25%.

Julliard will never accept such patch. In the hacks.git tree there is a
patch I did that has a configuration time option for it. It would be
cleaner if you used something like 'make SKIPTESTS=1'. I doubt that
alexandre would ever accept any patch that would disable building tests,
though.

Cheers,
Maarten.

makefiles: add a notest target

[Michael Stefaniuc]

Maarten Lankhorst wrote:
> Lei Zhang schreef:
> > This patch adds a notest target to build everything but the dll unit
> > tests and winetest. This cuts down build time by 25%.
>
> Julliard will never accept such patch. In the hacks.git tree there is a
> patch I did that has a configuration time option for it. It would be
> cleaner if you used something like 'make SKIPTESTS=1'. I doubt that
> alexandre would ever accept any patch that would disable building tests,
> though.

And for a good reason. The tests started to rot and not even compile
when building wasn't part of the default make target.

bye
    michael

makefiles: add a notest target

[Lei Zhang]

On 10/26/07, Michael Stefaniuc  wrote:
> Maarten Lankhorst wrote:
> > Lei Zhang schreef:
> > > This patch adds a notest target to build everything but the dll unit
> > > tests and winetest. This cuts down build time by 25%.
> >
> > Julliard will never accept such patch. In the hacks.git tree there is a
> > patch I did that has a configuration time option for it. It would be
> > cleaner if you used something like 'make SKIPTESTS=1'. I doubt that
> > alexandre would ever accept any patch that would disable building tests,
> > though.
>
> And for a good reason. The tests started to rot and not even compile
> when building wasn't part of the default make target.
>
> bye
>         michael
> --
> Michael Stefaniuc               Tel.: [phone]
> Sr. Network Engineer            Fax.: [phone]
>
> Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart
> Handelsregister: Amtsgericht Stuttgart HRB 153243
> Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham,
>                  Werner Knoblich

This is not meant to be the default make target. I intended for it to
be a time saver when one just needs a quick build, like when doing
regression testing.

Perhaps its better just to keep this out of the Wine tree, and let
people apply the patch if they know what they're doing.