Re: [PATCH] Wine's ChangeDisplaySettingsEx is too strict

[Dmitry Timoshkov]

"Szombathelyi György"  wrote:
> The game changes display resolution with ChangeDisplaySettingsEx, but doesn't
> specify DM_PELSWIDTH and DM_PELSHEIGHT at devmode->dmFields, so it quits
> early with an error message. Of course, it works on windows. So I attached a
> patch which make wine WinXP compatible...Hope you accept it.

Please add a test case for this to dlls/user32/tests/monitor.c.

[PATCH] Wine's ChangeDisplaySettingsEx is too strict

[Szombathelyi György]

Ezzel a dátummal: Sunday 20 January 2008 05.33.28 Dmitry Timoshkov ezt írta:
> "Szombathelyi György"  wrote:
> > The game changes display resolution with ChangeDisplaySettingsEx, but
> > doesn't specify DM_PELSWIDTH and DM_PELSHEIGHT at devmode->dmFields, so
> > it quits early with an error message. Of course, it works on windows. So
> > I attached a patch which make wine WinXP compatible...Hope you accept it.
>
> Please add a test case for this to dlls/user32/tests/monitor.c.

Here's the test (the game above uses similar parameters, only 
DM_DISPLAYFREQUENCY in dmFields, but all other dmxxx members are filled in). 
But now test 9 and 10 fails with my patch (the return code from 
ChangeDisplaySettingsEx now 0=OK). Are they really fails on Windows? The last 
test failed already in wine, without my patch.

Regards,
György