Re: [PATCH 3/3] advapi32: Add support for using the Mac Keychain services as a backend for the credential functions instead of the registry.

[Juan Lang]

Hi Rob,

@@ -232,6 +239,198 @@ static DWORD registry_read_credential(HKEY hkey,
PCREDENTIALW credential,
     return ret;
 }

+static DWORD mac_read_credential_from_item(SecKeychainItemRef item,
BOOL require_password,
+                                           PCREDENTIALW credential,
char *buffer,
+                                           DWORD *len)

You're missing compilation protection here (and elsewhere) on non-Apple systems.
--Juan

[PATCH 3/3] advapi32: Add support for using the Mac Keychain services as a backend for the credential functions instead of the registry.

[Robert Shearman]

Juan Lang wrote:
> Hi Rob,
>
> @@ -232,6 +239,198 @@ static DWORD registry_read_credential(HKEY hkey,
> PCREDENTIALW credential,
>      return ret;
>  }
>
> +static DWORD mac_read_credential_from_item(SecKeychainItemRef item,
> BOOL require_password,
> -
>                                       PCREDENTIALW credential,
>
> char *buffer,
> -
>                                       DWORD *len)
>
> You're missing compilation protection here (and elsewhere) on non-Apple systems.

Ah, yes. Thanks!