build problem on current cvs

[Stefan Leichter]

Hello,

i hope you all had nice Christmas.

Now back to business :-)

trying to build current cvs (~7:45 AM UTC) i get the error:

make[1]: Entering directory `/usr/src/wine/wine-build/include'
../tools/widl/widl -I../../wine/include -I. -I../../wine/include -I../include    
-h -H oaidl.h ../../wine/include/oaidl.idl

../../wine/include/wtypes.idl:1: Oops, segment violation
make[1]: *** [oaidl.h] Abgebrochen
make[1]: *** Datei »oaidl.h« wird gelöscht
make[1]: Leaving directory `/usr/src/wine/wine-build/include'
make: *** [include] Fehler 2

My system is still SuSE 9.0. I am doing 'out of tree' builds.

Bye Stefan

[Jacek Caban]

Hi.

Stefan Leichter wrote:
> Hello,
>
> i hope you all had nice Christmas.
>
> Now back to business :-)
>
> trying to build current cvs (~7:45 AM UTC) i get the error:
>
> make[1]: Entering directory `/usr/src/wine/wine-build/include'
> ../tools/widl/widl -I../../wine/include -I. -I../../wine/include -I../include    
> -h -H oaidl.h ../../wine/include/oaidl.idl
>
> ../../wine/include/wtypes.idl:1: Oops, segment violation
> make[1]: *** [oaidl.h] Abgebrochen
> make[1]: *** Datei »oaidl.h« wird gelöscht
> make[1]: Leaving directory `/usr/src/wine/wine-build/include'
> make: *** [include] Fehler 2
>
> My system is still SuSE 9.0. I am doing 'out of tree' builds.
>
> Bye Stefan

Did you do make depend?

Thanks,
    Jacek

[Stefan Leichter]

Am Dienstag, 28. Dezember 2004 11:15 schrieb Jacek Caban:
> Hi.
>
> Stefan Leichter wrote:
> > Hello,
> >
> > i hope you all had nice Christmas.
> >
> > Now back to business :-)
> >
> > trying to build current cvs (~7:45 AM UTC) i get the error:
> >
> > make[1]: Entering directory `/usr/src/wine/wine-build/include'
> > ../tools/widl/widl -I../../wine/include -I. -I../../wine/include
> > -I../include -h -H oaidl.h ../../wine/include/oaidl.idl
> >
> > ../../wine/include/wtypes.idl:1: Oops, segment violation
> > make[1]: *** [oaidl.h] Abgebrochen
> > make[1]: *** Datei »oaidl.h« wird gelöscht
> > make[1]: Leaving directory `/usr/src/wine/wine-build/include'
> > make: *** [include] Fehler 2
> >
> > My system is still SuSE 9.0. I am doing 'out of tree' builds.
> >
> > Bye Stefan
>
> Did you do make depend?
>
> Thanks,
>     Jacek

this happens for me during make depend ;-)

Thanks Stefan

[Jacek Caban]

Stefan Leichter wrote:
> Am Dienstag, 28. Dezember 2004 11:15 schrieb Jacek Caban:
> > Hi.
> >
> > Stefan Leichter wrote:
> > > Hello,
> > >
> > > i hope you all had nice Christmas.
> > >
> > > Now back to business :-)
> > >
> > > trying to build current cvs (~7:45 AM UTC) i get the error:
> > >
> > > make[1]: Entering directory `/usr/src/wine/wine-build/include'
> > > ../tools/widl/widl -I../../wine/include -I. -I../../wine/include
> > > -I../include -h -H oaidl.h ../../wine/include/oaidl.idl
> > >
> > > ../../wine/include/wtypes.idl:1: Oops, segment violation
> > > make[1]: *** [oaidl.h] Abgebrochen
> > > make[1]: *** Datei »oaidl.h« wird gelöscht
> > > make[1]: Leaving directory `/usr/src/wine/wine-build/include'
> > > make: *** [include] Fehler 2
> > >
> > > My system is still SuSE 9.0. I am doing 'out of tree' builds.
> > >
> > > Bye Stefan
> >
> > Did you do make depend?
> >
> > Thanks,
> >    Jacek
>
> this happens for me during make depend ;-)
>
> Thanks Stefan

Could you try debug widl by gdb? Try:
$ gdb --args ../tools/widl/widl -I../../wine/include -I.
-I../../wine/include -I../include -h -H oaidl.h ../../wine/include/oaidl.idl

[Stefan Leichter]

Am Dienstag, 28. Dezember 2004 23:47 schrieb Jacek Caban:
> Stefan Leichter wrote:
> > Am Dienstag, 28. Dezember 2004 11:15 schrieb Jacek Caban:
> > > Hi.
> > >
> > > Stefan Leichter wrote:
> > > > Hello,
> > > >
> > > > i hope you all had nice Christmas.
> > > >
> > > > Now back to business :-)
> > > >
> > > > trying to build current cvs (~7:45 AM UTC) i get the error:
> > > >
> > > > make[1]: Entering directory `/usr/src/wine/wine-build/include'
> > > > ../tools/widl/widl -I../../wine/include -I. -I../../wine/include
> > > > -I../include -h -H oaidl.h ../../wine/include/oaidl.idl
> > > >
> > > > ../../wine/include/wtypes.idl:1: Oops, segment violation
> > > > make[1]: *** [oaidl.h] Abgebrochen
> > > > make[1]: *** Datei »oaidl.h« wird gelöscht
> > > > make[1]: Leaving directory `/usr/src/wine/wine-build/include'
> > > > make: *** [include] Fehler 2
> > > >
> > > > My system is still SuSE 9.0. I am doing 'out of tree' builds.
> > > >
> > > > Bye Stefan
> > >
> > > Did you do make depend?
> > >
> > > Thanks,
> > >    Jacek
> >
> > this happens for me during make depend ;-)
> >
> > Thanks Stefan
>
> Could you try debug widl by gdb? Try:
> $ gdb --args ../tools/widl/widl -I../../wine/include -I.
> -I../../wine/include -I../include -h -H oaidl.h
> ../../wine/include/oaidl.idl

Hello,

this problem confuses me. I have started regession testing. It turn out to be 
a problem of 'out of tree' builds and the name of the directory containing 
the cvs tree. If i use the cvs tree as checked out from winehq widl crashes. 
If i rename the main directory wine of the cvs tree to wine-saved1 widl 
works. It looks like the length of the name makes this difference wine-123456 
works also. Shorter names crash widl but in different files. If i build wine 
in the cvs tree itself it works too.

Logfile of gdb session attached.

Thanks Stefan

[Michael Stefaniuc]

Stefan Leichter wrote:
> this problem confuses me. I have started regession testing. It turn out to be 
> a problem of 'out of tree' builds and the name of the directory containing 
> the cvs tree. If i use the cvs tree as checked out from winehq widl crashes. 
> If i rename the main directory wine of the cvs tree to wine-saved1 widl 
> works. It looks like the length of the name makes this difference wine-123456 
> works also. Shorter names crash widl but in different files. If i build wine 
> in the cvs tree itself it works too.

I'm doing only out of tree builds and my source directories are named 
wine. But my path to those wine directories are longer than yours. One 
is an absolute path (different file systems) the other two directory 
layers more then yours (-I../../../source/wine/include). I never 
encountered a crash.

bye
    michael

[Jacek Caban]

Hello.
> Hello,
>
> this problem confuses me. I have started regession testing. It turn out to be 
> a problem of 'out of tree' builds and the name of the directory containing 
> the cvs tree. If i use the cvs tree as checked out from winehq widl crashes. 
> If i rename the main directory wine of the cvs tree to wine-saved1 widl 
> works. It looks like the length of the name makes this difference wine-123456 
> works also. Shorter names crash widl but in different files. If i build wine 
> in the cvs tree itself it works too.

I tried to reproduce a youre situation, but even with the same directory 
names widl didn't crash.
> Logfile of gdb session attached.
>
> Thanks Stefan
>
> GNU gdb 5.3.92
> Copyright 2003 Free Software Foundation, Inc.
> GDB is free software, covered by the GNU General Public License, and you are
> welcome to change it and/or distribute copies of it under certain conditions.
> Type "show copying" to see the conditions.
> There is absolutely no warranty for GDB.  Type "show warranty" for details.
> This GDB was configured as "i586-suse-linux"...
> (gdb) r
> Starting program: /usr/src/wine/wine-build/tools/widl/widl -I../../wine/include -I. -I../../wine/include -I../include -h -H oaidl.h ../../wine/include/oaidl.idl
>
> Program received signal SIGSEGV, Segmentation fault.
> 0x4009e05a in _int_malloc () from /lib/i686/libc.so.6
> (gdb) bt
> #0  0x4009e05a in _int_malloc () from /lib/i686/libc.so.6
> #1  0x4009d06c in malloc () from /lib/i686/libc.so.6
> #2  0x080525a0 in pp_xmalloc (size=11) at ../../../wine/libs/wpp/preproc.c:80
> #3  0x0805264a in pp_xstrdup (str=0xbfffec68 ""11:25:54"")
>    at ../../../wine/libs/wpp/preproc.c:108

It is probably caused by overwritting the allocated memory. The last 
changes of widl look well so I think it is
some old hidden problem. Lookng at code I found a potential bug, but I'm 
not sure if it a bug. In parsers,
both widl's and wpp's, strings are not duplicated whie adding to 
structures. If it helps, I'll see if it is correct at all.
This is included in diffs: wppppy.diff and widl.diff. Could you try it? 
I also found another small bug in wpp, but
it's not what we're looking for. I included it with some code cleanup in 
wpppreproc.diff.

Thanks,
    Jacek

[Stefan Leichter]

Am Mittwoch, 29. Dezember 2004 21:26 schrieb Jacek Caban:
> Hello.
> > Hello,
> >
> > this problem confuses me. I have started regession testing. It turn out to
> > be a problem of 'out of tree' builds and the name of the directory
> > containing the cvs tree. If i use the cvs tree as checked out from winehq
> > widl crashes. If i rename the main directory wine of the cvs tree to
> > wine-saved1 widl works. It looks like the length of the name makes this
> > difference wine-123456 works also. Shorter names crash widl but in
> > different files. If i build wine in the cvs tree itself it works too.
>
> I tried to reproduce a youre situation, but even with the same directory
> names widl didn't crash.
> > Logfile of gdb session attached.
> >
> > Thanks Stefan
> >
> > GNU gdb 5.3.92
> > Copyright 2003 Free Software Foundation, Inc.
> > GDB is free software, covered by the GNU General Public License, and you
> > are welcome to change it and/or distribute copies of it under certain
> > conditions. Type "show copying" to see the conditions.
> > There is absolutely no warranty for GDB.  Type "show warranty" for
> > details. This GDB was configured as "i586-suse-linux"...
> > (gdb) r
> > Starting program: /usr/src/wine/wine-build/tools/widl/widl
> > -I../../wine/include -I. -I../../wine/include -I../include -h -H oaidl.h
> > ../../wine/include/oaidl.idl
> >
> > Program received signal SIGSEGV, Segmentation fault.
> > 0x4009e05a in _int_malloc () from /lib/i686/libc.so.6
> > (gdb) bt
> > #0  0x4009e05a in _int_malloc () from /lib/i686/libc.so.6
> > #1  0x4009d06c in malloc () from /lib/i686/libc.so.6
> > #2  0x080525a0 in pp_xmalloc (size=11) at
> > ../../../wine/libs/wpp/preproc.c:80 #3  0x0805264a in pp_xstrdup
> > (str=0xbfffec68 ""11:25:54"")
> >    at ../../../wine/libs/wpp/preproc.c:108
>
> It is probably caused by overwritting the allocated memory. The last
> changes of widl look well so I think it is
> some old hidden problem. Lookng at code I found a potential bug, but I'm
> not sure if it a bug. In parsers,
> both widl's and wpp's, strings are not duplicated whie adding to
> structures. If it helps, I'll see if it is correct at all.
> This is included in diffs: wppppy.diff and widl.diff. Could you try it?
> I also found another small bug in wpp, but
> it's not what we're looking for. I included it with some code cleanup in
> wpppreproc.diff.
>
> Thanks,
>     Jacek

Hello Jacek,

good shot, applying the three patches fixes my build problem.

Many thanks
Stefan