Re: New valgrind results for Oct 26, 2009

[André Hentschel]

Dan Kegel schrieb:
> 2009/10/28 André Hentschel :
> > I think i found a false postitv. its http://kegel.com/wine/valgrind/logs/2009-10-26-08.26/vg-ntdll_env.txt
> > the code in ntdll/tests/env.c looks like:
> >        ...
> >        name.Buffer = bn;
> >        ...
> >        value.Buffer = bv;
> >        ...
> >        nts = pRtlQueryEnvironmentVariable_U(small_env, &name, &value);
> >        ...
> >        if(memcmp(bv, bn, test->len*sizeof(WCHAR)) == 0)
> >
> > So valgrind thinks bn and bv are uninitialised, but thats wrong.
> > Do you agree with me?
>
> I actually looked at this one for an hour the other day.
> I think valgrind's probably right, but the test is confusingly written.

So i send this issue to wine-devel to know what other devs think about it.