On 21 May 2013 13:18, Stefan Dösinger stefan@codeweavers.com wrote:
+static void test_coop_level_versions(void)
It may make more sense to move that to ddraw2.c and ddraw4.c instead. (IIRC you can't QI a ddraw1 interface from ddraw7.)
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2013-05-21 16:03, schrieb Henri Verbeet:
On 21 May 2013 13:18, Stefan Dösinger stefan@codeweavers.com wrote:
+static void test_coop_level_versions(void)
It may make more sense to move that to ddraw2.c and ddraw4.c instead.
The reasoning behind putting this in ddraw1 is that ddraw1 has the behavior that differs from the others.
(IIRC you can't QI a ddraw1 interface from ddraw7.)
ddraw1<->ddraw7 works fine, ddraw{1-4}->d3d7 and ddraw7->{d3d1-3} doesn't work.
I'll look into your comments for the actual patch tomorrow.
On 21 May 2013 21:09, Stefan Dösinger stefandoesinger@gmail.com wrote:
Am 2013-05-21 16:03, schrieb Henri Verbeet:
On 21 May 2013 13:18, Stefan Dösinger stefan@codeweavers.com wrote:
+static void test_coop_level_versions(void)
It may make more sense to move that to ddraw2.c and ddraw4.c instead.
The reasoning behind putting this in ddraw1 is that ddraw1 has the behavior that differs from the others.
Yeah, I figured, but you're actually testing ddraw2 behaviour there, and not covering ddraw4 and ddraw7 at all.
-
Henri Verbeet -
Stefan Dösinger