Re: (try 3) imm32: there is only 1 default Hwnd per thread

[Alexandre Julliard]

Aric Stewart  writes:
> - if (data->imeWnd == NULL)
> - if (defWnd == NULL)
> {
>     /* create the ime window */
> -
>    data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW,
> -
>    defWnd = CreateWindowExW( WS_EX_TOOLWINDOW,
>                data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0,
>                0, data->immKbd->hIME, 0);
> -
>    SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data);
> -
>    IMM_GetThreadData()->hwndDefault = data->imeWnd;
> -
>    SetWindowLongPtrW(defWnd, IMMGWL_IMC, (LONG_PTR)data);
> -
>    IMM_GetThreadData()->hwndDefault = defWnd;

So now, shouldn't you be resetting IMMGWL_IMC at some point?

(try 3) imm32: there is only 1 default Hwnd per thread

[Aric Stewart]

On 9/26/12 10:18 AM, Alexandre Julliard wrote:
> Aric Stewart  writes:
> > - if (data->imeWnd == NULL)
> > - if (defWnd == NULL)
> >  {
> >      /* create the ime window */
> > -
> >    data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW,
> > -
> >    defWnd = CreateWindowExW( WS_EX_TOOLWINDOW,
> >                 data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0,
> >                 0, data->immKbd->hIME, 0);
> > -
> >    SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data);
> > -
> >    IMM_GetThreadData()->hwndDefault = data->imeWnd;
> > -
> >    SetWindowLongPtrW(defWnd, IMMGWL_IMC, (LONG_PTR)data);
> > -
> >    IMM_GetThreadData()->hwndDefault = defWnd;
>
> So now, shouldn't you be resetting IMMGWL_IMC at some point?

Yeah, I am digging into that as we speak. My testing on testbot is not giving me any real rational results on that area. At least nothing matching my documentation as to how it is suppose to work. I need to get my Japanese VM back up and working and really try to dig into that.

Right now it is working and more correct that it was. My guess is that we should not be dealing with IMMGWL_IMC at all at that point anyway.

Do you want to delay on this fix until I figure our what should be happening with IMMGWL_IMC. Or I can have a second patch addressing IMMGWL_IMC and how that is suppose to be handled.

-aric

(try 3) imm32: there is only 1 default Hwnd per thread

[Alexandre Julliard]

Aric Stewart  writes:
> Do you want to delay on this fix until I figure our what should be
> happening with IMMGWL_IMC. Or I can have a second patch addressing
> IMMGWL_IMC and how that is suppose to be handled.

I think a few more test cases would be a good idea at this point.

(try 3) imm32: there is only 1 default Hwnd per thread

[Aric Stewart]

Ok I will continue my investigates and try to resolve this or at least generate good test cases.

This would also be easier with the thread work with user handles that I have needed in imm32 for longer than I remember the details about. :)

But they relate to patches
8d12fc61d5321350ad63b173bdfb50feef1f4b56
and
cc945706a4933cda0d204ba07a13e93fccb66d18

-aric

On 9/26/12 10:26 AM, Alexandre Julliard wrote:
> Aric Stewart  writes:
> > Do you want to delay on this fix until I figure our what should be
> > happening with IMMGWL_IMC. Or I can have a second patch addressing
> > IMMGWL_IMC and how that is suppose to be handled.
>
> I think a few more test cases would be a good idea at this point.