Re: [PATCH] dwrite/tests: Some tests for DWRITE_FONT_FACE_TYPE_RAW_CFF

[Alexandre Julliard]

Nikolay Sivov  writes:
> Signed-off-by: Nikolay Sivov
>
> dlls/dwrite/tests/Makefile.in       |   3 +-
>  dlls/dwrite/tests/font.c            | 230 ++++++++++++++++++++++++++++++++-
>  dlls/dwrite/tests/resource.rc       |   2 +
>  dlls/dwrite/tests/wine_test_cff.otf | Bin 0 -> 1900 bytes
>  dlls/dwrite/tests/wine_test_cff.sfd | 244 ++++++++++++++++++++++++++++++++++++

Is there a reason this needs to be a .otf file? That's not supported by
the build process.

[PATCH] dwrite/tests: Some tests for DWRITE_FONT_FACE_TYPE_RAW_CFF

[Nikolay Sivov]

On 18.11.2015 17:14, Alexandre Julliard wrote:
> Nikolay Sivov  writes:
> > Signed-off-by: Nikolay Sivov
> >
> > dlls/dwrite/tests/Makefile.in       |   3 +-
> >   dlls/dwrite/tests/font.c            | 230 ++++++++++++++++++++++++++++++++-
> >   dlls/dwrite/tests/resource.rc       |   2 +
> >   dlls/dwrite/tests/wine_test_cff.otf | Bin 0 -> 1900 bytes
> >   dlls/dwrite/tests/wine_test_cff.sfd | 244 ++++++++++++++++++++++++++++++++++++
>
> Is there a reason this needs to be a .otf file? That's not supported by
> the build process.

No, file name is irrelevant, otf was to make it clear it's postscript 
kind. Does it mean I'll need build system changes anyway (is it in 
makedep?) to tell fontforge to generate opentype with cff in it?

Is it a maintainer mode that rebuilds them?

[PATCH] dwrite/tests: Some tests for DWRITE_FONT_FACE_TYPE_RAW_CFF

[Alexandre Julliard]

Nikolay Sivov  writes:
> On 18.11.2015 17:14, Alexandre Julliard wrote:
> > Nikolay Sivov  writes:
> > > Signed-off-by: Nikolay Sivov
> > >
> > > dlls/dwrite/tests/Makefile.in       |   3 +-
> > >   dlls/dwrite/tests/font.c            | 230 ++++++++++++++++++++++++++++++++-
> > >   dlls/dwrite/tests/resource.rc       |   2 +
> > >   dlls/dwrite/tests/wine_test_cff.otf | Bin 0 -> 1900 bytes
> > >   dlls/dwrite/tests/wine_test_cff.sfd | 244 ++++++++++++++++++++++++++++++++++++
> >
> > Is there a reason this needs to be a .otf file? That's not supported by
> > the build process.
>
> No, file name is irrelevant, otf was to make it clear it's postscript
> kind. Does it mean I'll need build system changes anyway (is it in
> makedep?) to tell fontforge to generate opentype with cff in it?

If it needs a special command, yes, it will need changes. I can take
care of it if you tell me what you need.
> Is it a maintainer mode that rebuilds them?

Yes.