January 2023 - wine-gitlab

[PATCH 0/1] MR1906: wined3d: Clamp the bound buffer range to the buffer size.
by Stefan Dösinger (＠stefan) 10 Jan '23

10 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53671 --- Unless the application sets something, we use WINED3D_MAX_CONSTANT_BUFFER_SIZE * sizeof(vec4). https://registry.khronos.org/OpenGL-Refpages/gl4/html/glBindBufferRange.xht… says it is an error to set offset + size larger than the buffer size. I don't know why other drivers aren't rejecting our call. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1906

4 3

[PATCH 0/1] MR1928: dwmapi: Fill qpcVBlank in DwmGetCompositionTimingInfo().
by Paul Gofman (＠gofman) 09 Jan '23

09 Jan '23

Since commit 182feddd4b02e83f3c69863bc2e6e63945eb2df1 DwmGetCompositionTimingInfo() returns success. Currently wine-gecko fails to display anything if prefix version is Win10. That is due to zero qpcVBlank field in DwmGetCompositionTimingInfo() output which is currently missing. Before the referenced commit it was handling the failure (see gfx/thebes/gfxWindowsPlatform.cpp:VBlankLoop() (line 2840 in the current wine-gecko snapshot from https://sourceforge.net/p/wine/wine-gecko/ci/master/tree/). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1928

2 1

Re: [PATCH v2 0/1] MR1926: winex11.drv: Obtain icon info for icons passed to fetch_icon_data(). - approved
by Alexandre Julliard (＠julliard) 09 Jan '23

09 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1926

1 0

Re: [PATCH v5 0/4] MR1886: Fixing paste errors on edit control in Win10+. - approved
by Alexandre Julliard (＠julliard) 09 Jan '23

09 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1886

1 0

Re: [PATCH v2 0/1] MR1922: win32u: Initialize the tracking_info for NtUserDrawScrollBar params. - approved
by Alexandre Julliard (＠julliard) 09 Jan '23

09 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1922

1 0

Re: [PATCH v2 0/1] MR1920: iphlpapi: Handle errors from DnsQueryConfig(DnsConfigDnsServerList). - approved
by Alexandre Julliard (＠julliard) 09 Jan '23

09 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1920

1 0

Re: [PATCH v2 0/1] MR1905: win32u: Introduce a get_display_depth() helper to retrieve emulated display depth. - approved
by Alexandre Julliard (＠julliard) 09 Jan '23

09 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1905

1 0

Re: [PATCH v2 0/1] MR1923: faudio: Purge and clear notifcations on ShutDown - approved
by Alexandre Julliard (＠julliard) 09 Jan '23

09 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1923

1 0

[PATCH v11 0/8] MR729: windows.media.speech: Initial recognition session work.
by Bernhard Kölbl (＠besentv) 09 Jan '23

09 Jan '23

-- v11: windows.media.speech: Allow the recognition session worker to be paused. windows.media.speech: Add a worker thread to the recognition session. windows.media.speech/tests: Test starting, stopping, pausing and resuming the recognition session. windows.media.speech/tests: Test the recognizer state. windows.media.speech: Return IAsyncAction from session_PauseAsync. windows.media.speech: Return IAsyncAction from session_StopAsync. windows.media.speech: Do not force calling convention on internal callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/729

4 22

[PATCH v11 0/7] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 09 Jan '23

09 Jan '23

Implements navigation bar featuring: - back/forward buttons - go up button - address crumbs - hides crumbs when there's not enough space to display all of them - always shows at least 2 crumbs - truncating them if needed - first crumb is at least 56px - aligns label to the left if truncated - right clicking on the crumb, or free space, opens a menu with `Copy address as text` and `Edit address` options - reuses existing crumbs to avoid some flickering - overflow menu - ~~first crumb is always moved here~~ - removes the split, if there are no items in the menu - hidden crumbs are moved here - left ~~or right~~ click on the button starts address editing - address edit - accepts an existing path - expands environment variables, e.g. `%APPDATA%\Microsoft` -> `C:\users\%USERNAME%\AppData\Roaming\Microsoft` - errors with a `MessageBox` on nonexistent paths - refresh button - changes into go to button when editing address - DPI scaling Screenshots: ![navbar-crumbs-classic](/uploads/8c9a806b57f8e456fcbfd3cbc1ef3bb7/navbar-crumbs-classic.png) ![navbar-crumbs-light](/uploads/9c8a7acf9b55ae5ac182219edd45b65d/navbar-crumbs-light.png) ![navbar-edit-classic](/uploads/f68309bbc9200a8d8d4e3cd692179409/navbar-edit-classic.png) ![navbar-edit-light](/uploads/6798e79e6d2498a052b0ecbc2545c6e4/navbar-edit-light.png) ![navbar-120dpi-classic](/uploads/72abee382ab6171ff9c1b99a9065c845/navbar-120dpi-classic.png) ![navbar-120dpi-light](/uploads/538a030bc2028f8654d6c35d6f2825dd/navbar-120dpi-light.png) Remaining issues: - crumbs not lighting up when hovered sometimes - can be observed in current file dialog, hovering over dropdown arrow of a file type fixes it for a moment - crumbs flickering on address change sometimes - mostly when there's not enough space to display all of them - `DeferWindowPos` doesn't seem to be atomic in Wine, presumably is in native Windows? - unexpected address conversion for some PIDLs - e.g. `Desktop` -> `C:\users\%USERNAME%\Desktop`, which is an entirely different location - or `My Computer` into an empty string - known folders are not handled by address edit, e.g. `Desktop`, `My Computer` - icons are not DPI scaled - while writing this: ``` 0024:fixme:bitmap:NtGdiCreateBitmap planes = 0 0024:err:system:user_check_not_lock BUG: holding USER lock wine/dlls/win32u/sysparams.c:396: user_check_not_lock: Assertion `0' failed. wine: Assertion failed at address F7FF8549 (thread 0024), starting debugger... ``` - can't reproduce, happened when clicking on an item in overflow menu - race condition? cosmic ray? Addresses following bugs: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=50338 - https://bugs.winehq.org/show_bug.cgi?id=51855 (partially? no search box) -- v11: fixup: address edit | limited known folder support comdlg32: Add refresh/go to button to IFileDialog navigation bar. comdlg32: Add address edit to IFileDialog navigation bar. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. comdlg32: Add go up button to IFileDialog navigation bar. comdlg32: Add IFileDialog navigation bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/1857

4 13

2025

2024

2023

2022

wine-gitlab January 2023