June 2024 - wine-gitlab

[PATCH v4 0/7] MR5846: quartz: Set biSizeImage for WMV media type.
by Alfred Agrell (＠Alcaro) 19 Jun '24

19 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56769 -- v4: quartz/tests: Test that avi_decompressor_source_qc_Notify does not deadlock if called from a foreign thread during IMemInput_Receive. quartz: Allow concurrent calls to AVI decoder qc_Notify and Receive. msvfw32/tests: Test that Cinepak rejects unsupported output types. iccvid: Reject unsupported output types. quartz/tests: Add Cinepak test to avi splitter. winegstreamer: Make AVI splitter use end of previous frame if the current frame doesn't have a timestamp. winegstreamer: Implement AM_MEDIA_TYPE to wg_format converter for Cinepak video. https://gitlab.winehq.org/wine/wine/-/merge_requests/5846

2 7

[PATCH v8 0/7] MR5744: winegstreamer: Fix various Cinepak issues
by Alfred Agrell (＠Alcaro) 19 Jun '24

19 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56698 -- v8: quartz/tests: Test that avi_decompressor_source_qc_Notify does not deadlock if called from a foreign thread during IMemInput_Receive. quartz: Allow concurrent calls to AVI decoder qc_Notify and Receive. msvfw32/tests: Test that Cinepak rejects unsupported output types. iccvid: Reject unsupported output types. quartz/tests: Add Cinepak test to avi splitter. winegstreamer: Make AVI splitter use end of previous frame if the current frame doesn't have a timestamp. winegstreamer: Implement AM_MEDIA_TYPE to wg_format converter for Cinepak video. https://gitlab.winehq.org/wine/wine/-/merge_requests/5744

4 10

Re: [PATCH v5 0/7] MR5319: winemac.drv keyboard layout/dead key fixes
by Marc-Aurel Zent (＠mzent) 19 Jun '24

19 Jun '24

Rebased against master, but is still good as is. The French (and most likely other layouts) will require a more nuanced mapping, which would probably make this MR too big, but is also already done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5319#note_73698

1 0

Re: [PATCH v2 0/5] MR5879: winegstreamer: Implement stubs for h264 encoder.
by Rémi Bernon (＠rbernon) 19 Jun '24

19 Jun '24

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wg_transform.c: > - { > - gst_caps_unref(parsed_caps); > - parsed_caps = gst_caps_ref(src_caps); > - } > - > - if (!(element = find_element(GST_ELEMENT_FACTORY_TYPE_DECODER, parsed_caps, sink_caps)) > - || !append_element(transform->container, element, &first, &last)) > - goto out; > - break; > - > - case WG_MAJOR_TYPE_AUDIO: > - case WG_MAJOR_TYPE_VIDEO: > - break; > - case WG_MAJOR_TYPE_UNKNOWN: > - GST_FIXME("Format %u not implemented!", input_format.major_type); > + if (!transform_create_transcoder(transform, src_caps, &input_format, &first, &last)) Can we add an encoder element without changing all this code? It doesn't look like you need all the complicated converter sequence, maybe only a videoconvert (do you even need one?). I don't want to be a blocker but to be honest I'm a bit annoyed with the idea of having to rewrite the patches I am trying to upstream with transform media types. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5879#note_73696

1 0

Re: [PATCH v2 0/5] MR5879: winegstreamer: Implement stubs for h264 encoder.
by Rémi Bernon (＠rbernon) 19 Jun '24

19 Jun '24

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/video_encoder.c: > + TRACE("iface %p increasing refcount to %lu.\n", encoder, refcount); > + > + return refcount; > +} > + > +static ULONG WINAPI transform_Release(IMFTransform *iface) > +{ > + struct video_encoder *encoder = impl_from_IMFTransform(iface); > + ULONG refcount = InterlockedDecrement(&encoder->refcount); > + > + TRACE("iface %p decreasing refcount to %lu.\n", encoder, refcount); > + > + if (!refcount) > + { > + if (encoder->attributes) > + IMFAttributes_Release(encoder->attributes); You can remove the if. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5879#note_73695

1 0

[PATCH 0/1] MR5871: ntdll: Fix macOS build errors with Xcode 16.
by Brendan Shanks (＠bshanks) 19 Jun '24

19 Jun '24

LLVM 17 or 18 no longer allow non-private labels to appear between .cfi_startproc/endproc when targeting Mach-O. Similar fixes as in commit 295d521b11644fb76c36854336b13c2155bb7d79. Since this is needed for 2 out of 4 architectures, would it be better to do it for all 4 and then modify the shared `__wine_syscall_dispatcher_return()` prototype? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5871

3 2

[PATCH v3 0/1] MR5846: quartz: Set biSizeImage for WMV media type.
by Alfred Agrell (＠Alcaro) 19 Jun '24

19 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56769 -- v3: quartz: Implement AMT/WMT differences for WMV media type. https://gitlab.winehq.org/wine/wine/-/merge_requests/5846

3 4

[PATCH 0/2] MR5872: ddraw: Preserve d3d device state in ddraw_surface_create().
by Paul Gofman (＠gofman) 19 Jun '24

19 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5872

4 5

[PATCH 0/2] MR5877: winex11: Create a global vulkan instance for xrandr.
by Rémi Bernon (＠rbernon) 19 Jun '24

19 Jun '24

And the other cleanup suggested in https://gitlab.winehq.org/wine/wine/-/merge_requests/5835. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5877

3 3

Re: [PATCH v2 0/2] MR5835: win32u, winex11: Avoid using the win32u vulkan driver interface.
by Rémi Bernon (＠rbernon) 19 Jun '24

19 Jun '24

On Tue Jun 18 16:34:50 2024 +0000, Emil Velikov wrote: > Does the wine (pre)loader unload things on `exit()` or perhaps the > dependency on ntdll.so and(?) win32u.so, makes that impossible? > Either way, as you said there are bigger concerns than this one dlhandle. Well for instance the user driver is never unloaded, and it links and uses symbols from win32u directly, so neither of them will be unloaded. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5835#note_73682

1 0

2025

2024

2023

2022

wine-gitlab June 2024