November 2025 - wine-gitlab

[PATCH v8 0/2] MR9330: Draft: PickiconDlg
by Matthias Zorn (＠Matthias-Zorn.0178) 01 Nov '25

01 Nov '25

Added PickiconDlg dialog resources as a test -- v8: shell32: Implement PickIconDlg function https://gitlab.winehq.org/wine/wine/-/merge_requests/9330

2 2

[PATCH 0/1] MR9329: dlls/sane.ds, dlls/gphoto2.ds: Destroy Progress Dialogs with DestroyWindow instead of EndDialog
by Bernd Herd (＠herdsoft) 01 Nov '25

01 Nov '25

The TWAIN data sources sane.ds and gpoto.ds create progress dialogs with the WIN32 CreateDialog API in files ui.c When they need to destroy these windows, they call EndDialog. But EndDialog is meant for Modal Dialogs created by DialogBox, DialogBoxParam, DialogBoxInd and the like. Calling it for dialogs created by CreateDialog is undocumented behaviour. In the end, those progress dialogs are not destroyed (immediatly?) and can still be open when the application program closes the data source with the message. DG_CONTROL / DAT_IDENTITY / MSG_CLOSEDS This can then later cause a segfault if the sane.ds/gpoto2.ds gets unloaded with FreeLibrary so the dialog box procedure is no longer in memory. There is a workaround for this in dlls/twain_32/dsm_ctrl.c:220: ``` /* This causes crashes due to still open Windows, so leave out for now. * FreeLibrary (currentDS->hmod); */ ``` But the TWAIN organization offers their own DSM-Library twaindsm.dll, that does not contain this workaround so segfaults after an otherwise successful scan: https://github.com/twain/twain-dsm Using this patch, progress dialogs are closed with DestroyWindow instead of EndDialog and these segfaults do not occur any more. This would also allow to change the code in dsm_ctrl.c:220 to FreeLibrary the DS module again. I've tested that it works. But there is no evidence that that change would have benefits and it might have other disadvantages. Compatibility of twaindsm.dll with sane.ds requires one of my previous merge requests that are not yet in wine main tree. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9329

3 2

[PATCH 0/1] MR9328: dlls/sane.ds: Make comboboxes in property sheet high enough to properly drop down
by Bernd Herd (＠herdsoft) 01 Nov '25

01 Nov '25

When the sane.ds TWAIN data source displays it's user interface, it auto-generates a proprties dialog from the sane options for the current scanner. Oftenly this dialog contains windows ComboBox controls to choose between scan modes (gray / color) or resolutions. The ComboBox controls created are too flat to properly drop down, they only open about half a line height. This is difficult to use. This patch makes the control about 10 times the height of a string. The combox will not occupy more height than the elements that are filled in anyway. Behaviour before the patch: ![before.png](/uploads/80e328dde7c04c14e5a29b54fa6843a5/before.png){width=305 height=244} Behaviour after the patch: ![after.png](/uploads/49a0e1014974e4bc43637f6b0b02ba54/after.png){width=308 height=246} -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9328

3 2

[PATCH v2 0/5] MR9332: combase: Implement RoOriginateError.
by Vibhav Pant (＠vibhavp) 01 Nov '25

01 Nov '25

-- v2: combase: Implement RoOriginateError(W) and GetRestrictedErrorInfo. combase: Implement Ro{Get,Set}ErrorReportingFlags. combase/tests: Add tests for GetRestrictedErrorInfo. https://gitlab.winehq.org/wine/wine/-/merge_requests/9332

2 9

[PATCH 0/1] MR9335: crypt32/tests: Add null character to avoid buffer overrun (ASan).
by Bernhard Übelacker (＠bernhardu) 01 Nov '25

01 Nov '25

These tests give intentionally ascii strings to unicode expecting functions. Therefore add these null characters to make them appear terminated to unicode functions. [ASan report details](https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-10-18… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9335

2 1

[PATCH 0/5] MR9332: combase: Implement RoOriginateError.
by Vibhav Pant (＠vibhavp) 01 Nov '25

01 Nov '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9332

3 16

[PATCH 0/1] MR9333: dwrite: Add explicit inline helper for whitespace checks.
by Nikolay Sivov (＠nsivov) 01 Nov '25

01 Nov '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9333

2 1

Re: [PATCH v5 0/6] MR9032: opengl32: Support wow64 buffer storage and persistent memory mapping using Vulkan.
by QwertyChouskie (＠QwertyChouskie) 01 Nov '25

01 Nov '25

> Good point, thanks. It does seem possible to use that extension, but I think we also need to support Nvidia. We could maybe have it as an alternative, though I’m not sure there are cases where it would actually help (that is, cases where the extension is available but a sufficient Vulkan driver isn’t). r600 (assuming it supports this extension) is certainly one case that comes to mind for something that is reasonably performant for older games but doesn't support Vulkan. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9032#note_120313

1 0

[PATCH v3 0/3] MR9330: Draft: PickiconDlg
by Matthias Zorn (＠Matthias-Zorn.0178) 01 Nov '25

01 Nov '25

Added PickiconDlg dialog resources as a test -- v3: shell32: add PickIconDlg resoures and first needed helb procedure https://gitlab.winehq.org/wine/wine/-/merge_requests/9330

2 3

2025

2024

2023

2022

wine-gitlab November 2025