On Tue Jun 10 23:46:26 2025 +0000, Jinoh Kang wrote:
> Thanks for your insight. I understand, but IMHO it's a good idea not to
> include generated files since they introduce unnecessary merge conflicts.
> For example, adding a new syscall results in about half of
> `dlls/ntdll/ntsyscalls.h` to be rewritten. MRs that (1) add a syscall,
> and (2) include generated files will surely conflict each other.
But the patch is going to be edited before committing anyway, whether the generated changes are included or not, so I don't see the issue?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8244#note_106184
On Tue Jun 10 18:39:40 2025 +0000, Elizabeth Figura wrote:
> Where did this advice come from exactly? I've never heard Alexandre
> request that people not include generated files, only that it's not
> necessary, and I've seen plenty of patches accepted with generated
> changes. As far as I can tell "it's not necessary" got somehow warped
> into "you shouldn't" and then spread as common knowledge.
Thanks for your insight. I understand, but IMHO it's a good idea not to include generated files since they introduce unnecessary merge conflicts.
For example, adding a new syscall results in about half of `dlls/ntdll/ntsyscalls.h` to be rewritten. MRs that (1) add a syscall, and (2) include generated files will surely conflict each other.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8244#note_106172
Currently xdg_toplevel_config size hints are ignored if the config has state 0
to avoid spurrious re-sizing. However, if the window is currently configured
with a non-zero state, e.g. it is in fullscreen, then such an event from the
compositor indicates a switch to a floating window, in which case the size
hint should be respected.
Additionally, the check for whether the current size of a fullscreen window is compatible
with the compositor requested size would always return true regardless of size. Reading the
comments for `wayland_surface_config_is_compatible`, it seems that behavior is intended in
the other places the function is used, so that call was replaced with a simple size
comparison.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8279