July 2025 - wine-gitlab

Re: [PATCH v7 0/4] MR8595: comctl32: Separate v5 and v6.
by Nikolay Sivov (＠nsivov) 21 Jul '25

21 Jul '25

On Mon Jul 21 02:14:38 2025 +0000, Zhiyi Zhang wrote: > This is because Wine has a mechanism to load built-in DLLs (related to > WINEDLLOVERRIDES). For example, all Wine built-in DLLs in the wine > prefix have a built-in DLL signature. When loading such a DLL from the > prefix, Wine will redirect it to the one in the build dir or the > installed DLL dir. Please see find_builtin_dll(). This allows developers > not to update the wine prefix after every rebuild because the ones in > the build dir are loaded. This mechanism is also responsible for > selecting native DLLs in the wine prefix or Wine's builtin DLLs in the > build dir or installed DLL dir, depending on WINEDLLOVERRIDES or > EXTRADLLFLAGS = -Wb,--prefer-native. > Then, a problem with comctl32 is that both comctl32 v6 and v5 have the > same name, "comctl32.dll". So when loading comctl32 from > C:\Windows\WinSxS\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.2600.2982_none_deadbeef\comctl32.dll, > it gets redirected to "comctl32.dll" in the build dir, which is comctl32 > v5. So for comctl32 v6 to work, we need to add a special case for > comctl32 v6 and redirect it to "comctl32_v6.dll". Note that > "comctl32_v6.dll" only exists in the build dir or installed DLL dir, not > in the wine prefix. Having this check in ntdll looks too dirty to me. Will it work if we build v6 variant as --prefer-native? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8595#note_110480

1 0

[PATCH 0/2] MR8596: dsound: Check if 'cbPropData' for DSPROPERTY_Description1 is large enough
by Yeshun Ye (＠yeyeshun) 21 Jul '25

21 Jul '25

Avoid writing out of bounds. Signed-off-by: YeshunYe <yeyeshun(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8596

3 5

[PATCH v6 0/4] MR8595: comctl32: Separate v5 and v6.
by Zhiyi Zhang (＠zhiyi) 21 Jul '25

21 Jul '25

This MR separates comctl32 into v5 and v6. A full branch is at https://gitlab.winehq.org/zhiyi/wine/-/commits/comctl32-separation. The remaining commits are to remove items that shouldn't be in v5. comctl32-version_6 in wine-staging can be dropped after this MR. -- v6: comctl32: Separate v5 and v6. comctl32/tests: Add version tests. user32: Load version for comctl32 v6 window classes. comctl32/tests: Fix a window leak. https://gitlab.winehq.org/wine/wine/-/merge_requests/8595

2 4

Re: [PATCH v4 0/2] MR8285: kernelbase: Support extended paths in GetFinalPathNameByHandleW
by Michael Stopa (＠stomy) 21 Jul '25

21 Jul '25

Sorry to ping you @julliard but I didn't see a dedicated maintainer for `kernelbase` and would like to get this reviewed. I'd appreciate it if I could get this into the same release as !8293 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8285#note_110467

1 0

[PATCH v5 0/4] MR8595: comctl32: Separate v5 and v6.
by Zhiyi Zhang (＠zhiyi) 21 Jul '25

21 Jul '25

This MR separates comctl32 into v5 and v6. A full branch is at https://gitlab.winehq.org/zhiyi/wine/-/commits/comctl32-separation. The remaining commits are to remove items that shouldn't be in v5. comctl32-version_6 in wine-staging can be dropped after this MR. -- v5: comctl32: Separate v5 and v6. https://gitlab.winehq.org/wine/wine/-/merge_requests/8595

4 17

Re: [PATCH v8 0/1] MR8573: cmd: tab completion: Treat most delimiters as literals if user specified quotes.
by Joe Souza (＠JoeS209) 20 Jul '25

20 Jul '25

On Sun Jul 20 18:46:01 2025 +0000, Joe Souza wrote: > WCMD_parameter does not handle tab completion. This code here does. > The example path in the comment in this MR above does not work with tab > completion in current code. These changes fix that. Try the example > path with current code and then with my changes here to see for yourself. To be completely clear about this, create a directory named "[2025] Tax Documents" (without the quotes). Then, type ```"[2025] Ta<tab>```. Without my changes here, note that this is incorrectly completed to "[2025][2025] Tax Documents" (note the doubled "[2025][2025]"). This is mentioned in the original comment for the merge request above, but perhaps it wasn't clear. Next, create a file named something like "fil]e1.txt" (or a file containing pretty much any of the other delimiter characters), and test tab completion with those. The results will be incorrect with current code. My changes here fix that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8573#note_110453

1 0

[PATCH v19 0/8] MR6892: propsys: Implement IPropertyDescription for several known system properties.
by Vibhav Pant (＠vibhavp) 20 Jul '25

20 Jul '25

This MR adds a very basic implementation of `IPropertyDescription` for system defined properties (i.e, the ones in \<propkey.h\>). This is needed to support the [`Properties`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation.properties?view=winrt-26100) method for `IDeviceInformation` in Windows.Devices.Enumeration (!6874). -- v19: propsys: Implement IPropertyDescription for several known system properties. https://gitlab.winehq.org/wine/wine/-/merge_requests/6892

2 9

[PATCH 0/1] MR8606: ntdll: Add a stub for RtlQueryProcessHeapInformation().
by Jake Coppinger (＠jakecopp) 20 Jul '25

20 Jul '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8606

2 1

[PATCH v6 0/2] MR8367: shell32: Try to lookup icon, with fallback on failure
by James McDonnell (＠ElementalWarrior) 20 Jul '25

20 Jul '25

Try to lookup icon information from shell32.dll. If an icon is not found, default to the file icon. Instead of defaulting to -1, which was failing for Affinity Photo's installer. -- v6: shell32: add shield icon shell32: Try to lookup icon, with fallback on failure https://gitlab.winehq.org/wine/wine/-/merge_requests/8367

2 2

Re: [PATCH v8 0/1] MR8573: cmd: tab completion: Treat most delimiters as literals if user specified quotes.
by Joe Souza (＠JoeS209) 20 Jul '25

20 Jul '25

On Sun Jul 20 18:46:01 2025 +0000, eric pouech wrote: > I don't fully get why you need specific code here as WCMD_parameter (and > its variants) should already take care of not handling delimiters inside quotes WCMD_parameter does not handle tab completion. This code here does. The example path in the comment in this MR above does not work with tab completion in current code. These changes fix that. Try the example path with current code and then with my changes here to see for yourself. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8573#note_110438

1 0

2025

2024

2023

2022

wine-gitlab July 2025