September 2025 - wine-gitlab

[PATCH v3 0/5] MR8969: opengl32, win32u: Fix 16-bit PFD_DRAW_TO_BITMAP rendering.
by Zowie van Dillen (＠zowie) 20 Sep '25

20 Sep '25

This MR fixes 16-bit PFD_DRAW_TO_BITMAP rendering, as tested with SimGolf and Civilization 3. The fix isn't super performant since it involves a lot of back-and-forth between CPU and GPU, which is mostly noticeable when moving staff around in SimGolf — it slows to around two or three fps —, but on the plus side it does work, which is a straight upgrade over the current version of Wine. Couple of notes: * The third commit touches several different subsystems because I had to add a constant that's visible from both opengl32 and win32u. I wasn't sure how to write this down in the commit message. * There's a bug in LLVMpipe where a 32-bit pbuffer will cause it to crash. I opened an issue for it here: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13890. I needed a 32-bit pbuffer to make this work, so I added a special check that effectively disables 16-bit bitmap rendering for LLVMpipe. * I also had to use a workaround to make blitting & OpenGL rendering work together. I wrote about it pretty extensively below. ## Combining blitting & OpenGL rendering Something that's difficult about bitmap rendering is that it allows programs to combine OpenGL drawing with direct blitting onto bitmap memory. That's difficult to imitate with the pbuffer-based implementation because there's no way to replicate memory edits on the bitmap to the GPU-based pbuffer (since there's no API calls involved in the memory edit). This had to work to make the games actually work, so I used this workaround: Each time after overwriting the bitmap from the pbuffer, we clear the pbuffer with transparent. Also instead of "overwriting" the bitmap, we instead blend the pbuffer's pixels onto the bitmap. That way we're effectively overlaying the most recent OpenGL drawings on top of the bitmap. I'm pretty confident that that approach would also help with 32-bit and 24-bit bitmap rendering, but I don't know of any programs that use 32-bit or 24-bit bitmap rendering, so I wasn't able to check. I've just left 32-bit and 24-bit bitmaps as they were. While the workaround works really well for the games, I did have to edit another test because it used glReadPixels on 16-bit bitmaps. glReadPixels will grab pixels from the transparent-background pbuffer instead of the bitmap, which gives the wrong result. I'm not under the impression that any consumer programs use bitmap rendering together with glReadPixels (it doesn't make as much sense when you could just directly read the pixels from the bitmap), but it's possible to add a wrap_glReadPixels that grabs pixels from the bitmap in case of a 16-bit memory DC. It's not important to read but I wanted to write it down for the record: I also tried another workaround to make combining blitting & OpenGL work. The thought was to overwrite the pbuffer with the bitmap just before OpenGL draws to the pbuffer, to keep them in sync. It probably would have worked out if it was possible to add something to the front of the OpenGL command buffer in a glFinish/glFlush call — then I could have inserted glDrawPixels in the front, before all of the program's rendering operations —, but it's only possible to add things to the end of the command buffer unfortunately. I tried adding a wrapper to glBegin and glClear, which checks if they were the first render operation after a glFlush or glFinish. Unfortunately that didn't work at all. I'm guessing that Civ 3 and SimGolf still do direct bitmap edits after the first call to glBegin, so by the time the program gets to glFinish/glFlush the pixels that were uploaded in the glDrawPixels command are already stale (although I didn't really check). Anyhow, that approach was pretty fruitless. -- v3: win32u: Fix garbled 24-bit bitmap rendering win32u: Add support for 16-bit bitmaps to set_dc_pixel_format and flush_memory_dc. opengl32: Return a fake pixel format when requesting 16-bit bitmap rendering. opengl32/tests: Extend 16-bit bitmap rendering test. winex11: Refine PFD_DRAW_TO_BITMAP requirements. https://gitlab.winehq.org/wine/wine/-/merge_requests/8969

2 5

[PATCH v4 0/5] MR9000: win32u: Check the queue access time from the shared memory.
by Rémi Bernon (＠rbernon) 19 Sep '25

19 Sep '25

This is a step in the direction of continuously polling the queue fd on the server side, removing the need for ntsync to notify wineserver before / after waiting on the queue. For this my plan is to make win32u also notify wineserver to update the queue access time before waiting (through set_queue_mask), if it's been long enough. Then decide that a queue is hung based on whether it is signaled but access time is more than 5s ago (ie: neither get_message nor set_queue_mask are called regularly even though queue is signaled). On the server side, the queue fd would stop being polling once it gets ready, and win32u would notify wineserver after all the driver events have been processed, to start polling it again, as a separate request from the wait. -- v4: win32u: Check the queue access time from the shared memory. server: Use monotonic_time as queue access time base. win32u: Move the message queue access time to shared memory. server: Move hooks_count to the end of the queue_shm_t struct. server: Return early if there's no queue in queue requests. https://gitlab.winehq.org/wine/wine/-/merge_requests/9000

3 9

[PATCH 0/1] MR9016: po: Update Lithuanian translation.
by Aurimas Fišeras (＠AurimasF) 19 Sep '25

19 Sep '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9016

2 1

Re: [PATCH v2 0/6] MR9011: Cmd engine rewrite (part XXXV) - approved
by Alexandre Julliard (＠julliard) 19 Sep '25

19 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9011

1 0

Re: [PATCH v3 0/3] MR9005: ShowWindow paramater usage - approved
by Alexandre Julliard (＠julliard) 19 Sep '25

19 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9005

1 0

Re: [PATCH v2 0/2] MR9004: win32u: Avoid swapping / flushing drawables with destroyed windows. - approved
by Alexandre Julliard (＠julliard) 19 Sep '25

19 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9004

1 0

Re: [PATCH v3 0/1] MR9007: wmic: Add a basic help option "/?". - approved
by Alexandre Julliard (＠julliard) 19 Sep '25

19 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9007

1 0

Re: [PATCH v7 0/1] MR8928: msxml3/tests: add test for IXMLDOMElement_removeAttributeNode. - approved
by Alexandre Julliard (＠julliard) 19 Sep '25

19 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8928

1 0

Re: [PATCH v4 0/8] MR8966: d3dx: Miscellaneous fixes. - approved
by Alexandre Julliard (＠julliard) 19 Sep '25

19 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8966

1 0

Re: [PATCH v4 0/4] MR8991: iphlpapi: Implement GetBestRoute2() and GetBestInterfaceEx(). - approved
by Alexandre Julliard (＠julliard) 19 Sep '25

19 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8991

1 0

2025

2024

2023

2022

wine-gitlab September 2025