On Sun Dec 29 22:03:37 2024 +0000, Alex Henrie wrote:
> Based on feedback from Zeb and Fabian, I've improved the test to show
> that installation of the non-existent OCX fails unless its file name is
> prepended with the `@` sign. I hope that is convincing enough. At the
> very least, this patch does not make Wine any worse than it was before
> the regression.
A more convincing test would be to use a proper OCX and check whether it gets registered.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4878#note_117094
On Mon Sep 29 19:33:15 2025 +0000, Connor McAdams wrote:
> Noticed I was leaking `d3dx_image` data in patch 2 of this series and
> pushed a fix, it is not leaked in the final patch but might have caused
> issues in the case of a bisect or something. :)
Dropped the relevant review comment :slight_smile:
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/9034#note_117085