- wine-gitlab - winehq.org

[PATCH 0/5] MR8723: cfgmgr32: device query part 3: Add support for basic filter expressions.
by Vibhav Pant (＠vibhavp) 06 Aug '25

06 Aug '25

Support filter expressions consisting of basic comparison operators in DevGetObjects(Ex). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8723

2 5

[PATCH 0/1] MR8707: Draft: dxgi: Add IDXGIOutput::WaitForVBlank semi-stub
by Mike Kozelkov (＠augenzi) 06 Aug '25

06 Aug '25

Qt 6.9 Gui module on Windows with D3D 11 and 12 uses dedicated vblank watcher thread to update window (https://doc.qt.io/qt-6/whatsnew69.html). This thread calls IDXGIOutput::WaitForVBlank that must halt the thread until the next vblank occurs. This implementation is based on incorrect calculation of vblank occurrence. But it helps to update window. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8707

2 2

[PATCH 0/1] MR8270: mf: Prevent double submission of session commands.
by Yuxuan Shui (＠yshui) 06 Aug '25

06 Aug '25

This is not the right fix, and I need some help. Let me explain. `session_submit_command` checks that: 1. `session->commands` is empty, and 2. `SESSION_FLAG_PENDING_COMMAND` is NOT set before submitting the `session_op`. The assumption is, if there are queued commands, or if there is a command currently running, that pending command will submit subsequent commands when it completes. However, in this call chain: ``` #0 0x00006fffe1d27ad7 in create_async_result (object=object@entry=0x0, callback=callback@entry=0x7e62489f1c08, state=state@entry=0x7e61cb5322b0, out=out@entry=0x7e6242bac7a0) at ../dlls/rtworkq/queue.c:1229 #1 0x00006fffe1d222d5 in RtwqCreateAsyncResult (object=object@entry=0x0, callback=callback@entry=0x7e62489f1c08, state=state@entry=0x7e61cb5322b0, out=out@entry=0x7e6242bac7a0) at ../dlls/rtworkq/queue.c:1245 #2 0x00006fffd45e2096 in MFPutWorkItem (queue=queue@entry=1, callback=callback@entry=0x7e62489f1c08, state=state@entry=0x7e61cb5322b0) at ../dlls/mfplat/queue.c:46 #3 0x00006fffe41244ee in session_command_complete (session=0x7e62489f1be0) at ../dlls/mf/session.c:975 #4 0x00006fffe412d00f in session_reset (session=session@entry=0x7e62489f1be0) at ../dlls/mf/session.c:1051 #5 0x00006fffe41299fc in session_handle_source_shutdown (session=session@entry=0x7e62489f1be0) at ../dlls/mf/session.c:2957 #6 0x00006fffe4126e90 in session_events_callback_Invoke (iface=0x7e62489f1c20, result=<optimized out>) at ../dlls/mf/session.c:4445 ``` nowhere was the `SESSION_FLAG_PENDING_COMMAND` flag set. In addition to that, `session_events_callback_Invoke` is not a command. So this could happend: ``` Thread 1 | Thread 2 call session_events_callback_Invoke | | call session_submit_command | <critical section> | list_empty(&session->commands) is true, and PENDING_COMMAND not set | MFPutWorkItem(op) | list_add(&session->commands, op) <- (1) | </critical_section> call session_handle_source_shutdown | <critical_section> | call session_reset | call session_command_complete | list_head(&session->commands) | op is returned because of (1) | MFPutWorkItem(op) again | </critical_section> | ``` The result is this op will be executed twice, and also double freed, because `session_commands_callback_Invoke` releases the `op`. * * * There is even another way an `op` can be submitted twice, `session_handle_start_error` calls `session_reset`, which already calls `session_command_complete`, and later it calls `session_command_complete_with_event` again. I think a missing return? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8270

3 7

[PATCH v6 0/3] MR8243: d2d1: Support creating bitmap from DXGI subresource surface.
by Zhiyi Zhang (＠zhiyi) 06 Aug '25

06 Aug '25

For React Native -- v6: d2d1: Add initial support for creating bitmaps from DXGI subresource surfaces. d2d1/tests: Test creating bitmap from DXGI subresource surface. d2d1/tests: Silence some test traces. https://gitlab.winehq.org/wine/wine/-/merge_requests/8243

2 4

[PATCH v3 0/1] MR8713: widl: Fix crash while replacing type parameters for arrays.
by Vibhav Pant (＠vibhavp) 06 Aug '25

06 Aug '25

Fixes a crash with parameterized interfaces that have methods containing array argument(s). ``` namespace Test { interface ITest1<T>; [ uuid(006735f5-5f5d-4c39-9106-e1821b4caf04) ] interface ITest1<T> { void Method1([in] int a, [out, retval, size_is(a)]T *v); } declare { interface ITest1<int>; } } ``` widl: ../tools/widl/typegen.c:378: enum typegen_type typegen_detect_type(const type_t *, const attr_list_t *, unsigned int): Assertion `0' failed. -- v3: widl: Fix crash while replacing type parameters for arrays. https://gitlab.winehq.org/wine/wine/-/merge_requests/8713

3 3

[PATCH v6 0/1] MR8605: winebus: Do not touch autocenter on device reset and stop all effects
by Tomasz Pakuła (＠TomaszPakula) 06 Aug '25

06 Aug '25

FFB Autocenter introduced in https://gitlab.winehq.org/wine/wine/-/merge_requests/4911 had one major misunderstanding. The USB PID standard doesn't actually define any explicit way to autocenter a device. One could of course use the spring effect with a deadzone of 0 and dead band of 0. This is what I'm actually working on for the Linux PID driver (spring + friction/damper). Some devices implement autocenter in firmware when they receive the DC Disable Actuators command. Very few, if not just one, implement this weird autocenter effect on slot 1. This is, from what I can gather, only implemented on the MS SideWinder joystick(s) and the Windows' USB PID driver is created around these devices. Windows PID driver is a bit out of spec, is quite permissive when it comes to fields missing in the descriptor (basically, only effect types and their effect type blocks are optional). Another thing it does is handling of this out-of-spec autocentering for their joysticks. Funnliy enough, the creator of the Linux PID driver based the initial code on testing with MS Sidewinder so it's autocentering is supported. This is where the autocentering mentioned in the MR comes from. It's not the directinput api that does it but the Windows PID driver. As such, autocentering on reset should be left to the drivers, not handeled by Wine. SDL lacks full reset support and Linux is even more barebones, whre it's not even possible to query the device state, effects etc (something I'm working on slowly). As such, when games send out RESET to prepare the device, the device starts autocentering for no good reason and the effect is not removed once other effect are uploaded and played which would be the case for MS sidewinder. In any case, even Windows in inconsistent and I think the directinput documentation has some errors. directinput ffb api is largely based on USB PID but: ![image](/uploads/6548386550b874d2e5548f35f7fe76b0/image.png) ![image](/uploads/851484a555c744c6791d48b3fd194e91/image.png) Testing with my Moza Racing R9 wheelbase, the DC Reset PID command is sent, but there's no DC Disable Actuators in sight. The games still call reset then enable actuators though. tl;dr Set autocentering to 0 instead of max value when DISFFC_RESET is received to remove the unwanted autocenter behavior. Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny(a)gmail.com> -- v6: winebus: Do not touch autocenter on device init and device reset https://gitlab.winehq.org/wine/wine/-/merge_requests/8605

3 2

[PATCH v5 0/1] MR8605: winebus: Do not touch autocenter on device init, device reset and stop all effects
by Tomasz Pakuła (＠TomaszPakula) 06 Aug '25

06 Aug '25

FFB Autocenter introduced in https://gitlab.winehq.org/wine/wine/-/merge_requests/4911 had one major misunderstanding. The USB PID standard doesn't actually define any explicit way to autocenter a device. One could of course use the spring effect with a deadzone of 0 and dead band of 0. This is what I'm actually working on for the Linux PID driver (spring + friction/damper). Some devices implement autocenter in firmware when they receive the DC Disable Actuators command. Very few, if not just one, implement this weird autocenter effect on slot 1. This is, from what I can gather, only implemented on the MS SideWinder joystick(s) and the Windows' USB PID driver is created around these devices. Windows PID driver is a bit out of spec, is quite permissive when it comes to fields missing in the descriptor (basically, only effect types and their effect type blocks are optional). Another thing it does is handling of this out-of-spec autocentering for their joysticks. Funnliy enough, the creator of the Linux PID driver based the initial code on testing with MS Sidewinder so it's autocentering is supported. This is where the autocentering mentioned in the MR comes from. It's not the directinput api that does it but the Windows PID driver. As such, autocentering on reset should be left to the drivers, not handeled by Wine. SDL lacks full reset support and Linux is even more barebones, whre it's not even possible to query the device state, effects etc (something I'm working on slowly). As such, when games send out RESET to prepare the device, the device starts autocentering for no good reason and the effect is not removed once other effect are uploaded and played which would be the case for MS sidewinder. In any case, even Windows in inconsistent and I think the directinput documentation has some errors. directinput ffb api is largely based on USB PID but: ![image](/uploads/6548386550b874d2e5548f35f7fe76b0/image.png) ![image](/uploads/851484a555c744c6791d48b3fd194e91/image.png) Testing with my Moza Racing R9 wheelbase, the DC Reset PID command is sent, but there's no DC Disable Actuators in sight. The games still call reset then enable actuators though. tl;dr Set autocentering to 0 instead of max value when DISFFC_RESET is received to remove the unwanted autocenter behavior. Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny(a)gmail.com> -- v5: winebus: Do not touch autocenter on device init and device reset https://gitlab.winehq.org/wine/wine/-/merge_requests/8605

5 23

[PATCH 0/1] MR8719: winegstreamer: Only add the capsfilter for avdec_h264.
by Brendan McGrath (＠redmcg) 06 Aug '25

06 Aug '25

avdec_h264 will fail when combined with h264parse and a drain request is made during caps neg. To fix this, a capsfilter was added to force a stream-format of byte-stream for all h.264 decoders. However, this introduced a new issue with the vtdec element, as it only supports the avc stream-format. Therefore, this patch looks to address both problems by only introducing the capsfilter when the avdec_h264 element is used. It also removes the stream-format and alignment requirements from the parsed caps, applying them only to the capsfilter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8719

3 3

[PATCH v2 0/1] MR8713: widl: Fix crash while replacing type parameters for arrays.
by Vibhav Pant (＠vibhavp) 06 Aug '25

06 Aug '25

Fixes a crash with parameterized interfaces that have methods containing array argument(s). ``` namespace Test { interface ITest1<T>; [ uuid(006735f5-5f5d-4c39-9106-e1821b4caf04) ] interface ITest1<T> { void Method1([in] int a, [out, retval, size_is(a)]T *v); } declare { interface ITest1<int>; } } ``` widl: ../tools/widl/typegen.c:378: enum typegen_type typegen_detect_type(const type_t *, const attr_list_t *, unsigned int): Assertion `0' failed. -- v2: widl: Fix crash while replacing type parameters for arrays. https://gitlab.winehq.org/wine/wine/-/merge_requests/8713

3 2

[PATCH 0/6] MR8720: winedmo: Miscellaneous fixes.
by Rémi Bernon (＠rbernon) 06 Aug '25

06 Aug '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8720

2 6

2025

2024

2023

2022

wine-gitlab